[GitHub] [airflow] ashb commented on a change in pull request #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #7163: [AIRFLOW-6542] add spark-on-k8s operator/hook/sensor
URL: https://github.com/apache/airflow/pull/7163#discussion_r381554309
 
 

 ##########
 File path: airflow/providers/cncf/kubernetes/hooks/kubernetes_hook.py
 ##########
 @@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import tempfile
+
+from kubernetes import client, config
+
+from airflow.hooks.base_hook import BaseHook
+
+
+class Kuberneteshook(BaseHook):
+    """
+    Creates Kubernetes API connection.
+
+    :param conn_id: the connection to Kubernetes cluster
+    """
+
+    def __init__(
+        self,
+        conn_id="kubernetes_default"
+    ):
+        self.connection = self.get_connection(conn_id)
+        self.extras = self.connection.extra_dejson
+
+    def get_conn(self):
+        """
+        Returns kubernetes api session for use with requests
+        """
+
+        if self._get_field(("in_cluster")):
+            self.log.debug("loading kube_config from: in_cluster configuration")
+            config.load_incluster_config()
+        elif self._get_field("kube_config") is None or self._get_field("kube_config") == '':
+            self.log.debug("loading kube_config from: default file")
+        else:
+            with tempfile.NamedTemporaryFile() as temp_config:
+                self.log.debug("loading kube_config from: connection kube_config")
+                temp_config.write(self._get_field("kube_config").encode())
+                config.load_kube_config(temp_config.name)
+                temp_config.flush()
 
 Review comment:
   There's no point flushing the file _after_ it's been read by load_kube_config. Either the flush isn't needed, or it should be called before config.load_kube_config.
   
   Is there no option to load from a dict instead of having to write it to a temp file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services