[GitHub] [accumulo] Manno15 commented on pull request #1944: Closes #1929. Add property verification for Sampler Options

[GitBox <gi...@apache.org>]

Manno15 commented on pull request #1944:
URL: https://github.com/apache/accumulo/pull/1944#issuecomment-784199344


   > Another way you might provide early validation of these properties is to add some sort of options validation to samplers, either by adding a validateOptions method or similar to the interface as a default method, and then call it when validating the config. Or, the hanging issue could be addressed by ensuring any exception thrown in the sampler's init method will trigger an error in the logs and skip the sampler, rather than trigger a retry behavior that hangs.
   
   Do you know if users have to implement `AbstractHashSampler` when creating a new sampler? Most of the already configured samplers have validity checks already. Which is where the original error came from. Seems the best way to tackle this is to handle the hanging issue. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org