You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "cardigan1008 (via GitHub)" <gi...@apache.org> on 2023/06/11 07:15:37 UTC

[GitHub] [shardingsphere] cardigan1008 opened a new pull request, #26260: Add support for oracle sql like 'table(return_objects(5))'

cardigan1008 opened a new pull request, #26260:
URL: https://github.com/apache/shardingsphere/pull/26260

   Fixes #26060.
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on pull request #26260: Add support for oracle sql like 'table(return_objects(5))'

Posted by "taojintianxia (via GitHub)" <gi...@apache.org>.
taojintianxia commented on PR #26260:
URL: https://github.com/apache/shardingsphere/pull/26260#issuecomment-1738373693

   this PR will migrate to milestone 5.4.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add support for oracle sql like 'table(return_objects(5))' [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #26260:
URL: https://github.com/apache/shardingsphere/pull/26260#issuecomment-1956075901

   Since this pr has long time no response, I will close it. You can submit new pr when you are free.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cardigan1008 commented on pull request #26260: Add support for oracle sql like 'table(return_objects(5))'

Posted by "cardigan1008 (via GitHub)" <gi...@apache.org>.
cardigan1008 commented on PR #26260:
URL: https://github.com/apache/shardingsphere/pull/26260#issuecomment-1586480862

   @strongduanmu Sure, done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] github-actions[bot] commented on pull request #26260: Add support for oracle sql like 'table(return_objects(5))'

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26260:
URL: https://github.com/apache/shardingsphere/pull/26260#issuecomment-1677985264

   There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #26260: Add support for oracle sql like 'table(return_objects(5))'

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #26260:
URL: https://github.com/apache/shardingsphere/pull/26260#issuecomment-1586404518

   Hi @cardigan1008, can you fix code conflict?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add support for oracle sql like 'table(return_objects(5))' [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed pull request #26260: Add support for oracle sql like 'table(return_objects(5))'
URL: https://github.com/apache/shardingsphere/pull/26260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org