You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 10:24:14 UTC
[GitHub] [airflow] lwyszomi opened a new pull request #21890: Update google-cloud-spanner version
lwyszomi opened a new pull request #21890:
URL: https://github.com/apache/airflow/pull/21890
Update package to give users possibility to install `sqlalchemy-spanner`.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1068544174
@lwyszomi Yes. We should do it. Thanks to this, we will avoid dependency conflicts, because problems will be detected on the CI.
https://github.com/apache/airflow/blob/774ca085d2d2d58d4292b43c3511a145cc07154b/setup.py#L513-L516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1066548978
@mik-laj When we add `get_uri` method we should also extend this hook and add inheritance from `DbApiHook`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1055341895
To add support for `sqlalchemy-spanner`, we should also add `get_uri` method.
https://github.com/apache/airflow/blob/33edeb2cb1c83c61f2ce5981066228d10a77df5b/airflow/providers/snowflake/hooks/snowflake.py#L216-L219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1068978335
Yep. Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1069046059
Apparently, support (and test case suite) was added in January but the setup.py has not been updated :)
🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1060049412
Rebased it to latest main - let's see if it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1055276838
@potiuk Could you assign someone to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1069034851
> @potiuk @mik-laj This change for now is blocked because we have a issue with the dependencies. The Airflow supporting `sqlalchemy<1.4.10,>=1.4` but `sqlalchemy-spanner` supporting `sqlalchemy<=1.3.23,>=1.1.13`. Conflict for now cannot be resolved, we need to wait when `sqlalchemy-spanner` will support `sqlalchemy<1.4.10,>=1.4`.
Too bad. I opened issue for that: https://github.com/googleapis/python-spanner-sqlalchemy/issues/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1060265080
@potiuk @mik-laj I was offline most of the week, Thanks for feedback I will update my PR in this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1067941192
@mik-laj I have one more think in my mind, if we extend this hook maybe by default we should add `sqlalchemy-spanner` to the google provider packages, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1069022955
@potiuk @mik-laj This change for now is blocked because we have a issue with the dependencies. The Airflow supporting `sqlalchemy<1.4.10,>=1.4` but `sqlalchemy-spanner` supporting `sqlalchemy<=1.3.23,>=1.1.13`. Conflict for now cannot be resolved, we need to wait when `sqlalchemy-spanner` will support `sqlalchemy<1.4.10,>=1.4`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1069046059
Apparently, support (and test case suite) was added in January but the setup.py has not been updated :)
https://github.com/googleapis/python-spanner-sqlalchemy/issues/204#issuecomment-1069043474
🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
lwyszomi commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1069037219
@potiuk thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21890: Update google-cloud-spanner version
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21890:
URL: https://github.com/apache/airflow/pull/21890#issuecomment-1066974968
@lwyszomi , Yes. Thanks to this, we will be able to use it in other places where DBApiHook class is expected. Users will also not need to study this class specifically, as they will be able to rely on a unified interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org