You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 04:12:03 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #201: [FLINK-28384][hive] Add CatalogLock support for HiveCatalog in table store
JingsongLi opened a new pull request, #201:
URL: https://github.com/apache/flink-table-store/pull/201
In HiveCatalog, we can set CatalogLock.Factory to TableStoreSink to support multiple concurrency writers for object storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #201: [FLINK-28384][hive] Add CatalogLock support for HiveCatalog in table store
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #201:
URL: https://github.com/apache/flink-table-store/pull/201#discussion_r914635219
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/CatalogFactory.java:
##########
@@ -34,9 +34,9 @@ public interface CatalogFactory {
String identifier();
- Catalog create(String warehouse, ReadableConfig options);
+ Catalog create(String warehouse, Configuration options);
- static Catalog createCatalog(ReadableConfig options) {
+ static Catalog createCatalog(Configuration options) {
// manual validation
Review Comment:
I think we can let it go
If there is a situation where you need to configure some HiveClient parameters, you can do so through this channel.
At the beginning we can be a little more flexible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #201: [FLINK-28384][hive] Add CatalogLock support for HiveCatalog in table store
Posted by GitBox <gi...@apache.org>.
tsreaper commented on code in PR #201:
URL: https://github.com/apache/flink-table-store/pull/201#discussion_r914621187
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/CatalogFactory.java:
##########
@@ -34,9 +34,9 @@ public interface CatalogFactory {
String identifier();
- Catalog create(String warehouse, ReadableConfig options);
+ Catalog create(String warehouse, Configuration options);
- static Catalog createCatalog(ReadableConfig options) {
+ static Catalog createCatalog(Configuration options) {
// manual validation
Review Comment:
Now that we have a dedicated `CatalogOptions` class to hold all options, we can call the `validate` method and add those options into required or optional methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #201: [FLINK-28384][hive] Add CatalogLock support for HiveCatalog in table store
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #201:
URL: https://github.com/apache/flink-table-store/pull/201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org