You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/07/07 13:35:50 UTC
[GitHub] [ignite] xtern opened a new pull request, #10145: IGNITE-17296 .NET: Platform service interceptor.
xtern opened a new pull request, #10145:
URL: https://github.com/apache/ignite/pull/10145
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922182361
##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
w.WriteObject(NodeFilter);
else
w.WriteObject<object>(null);
+
+ if (Interceptors != null)
+ w.WriteCollection(Interceptors as ICollection);
Review Comment:
Agree, let's keep it simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922218900
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformAbstractService.java:
##########
@@ -240,11 +243,13 @@ public void setIgniteInstance(Ignite ignite) {
@Override public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
svc = in.readObject();
srvKeepBinary = in.readBoolean();
+ interceptors = in.readObject();
Review Comment:
Ok, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922209143
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/LazyServiceConfiguration.java:
##########
@@ -143,7 +142,7 @@ public byte[] interceptorBytes() {
if (name != null ? !name.equals(that.getName()) : that.getName() != null)
return false;
- if (!F.eq(srvcClsName, that.srvcClsName))
+ if (!Arrays.equals(srvcBytes, that.srvcBytes))
Review Comment:
Can you please explain this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922215698
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/Services.cs:
##########
@@ -501,6 +501,16 @@ private static void ValidateConfiguration(ServiceConfiguration configuration, st
IgniteArgumentCheck.NotNull(configuration, argName);
IgniteArgumentCheck.NotNullOrEmpty(configuration.Name, string.Format("{0}.Name", argName));
IgniteArgumentCheck.NotNull(configuration.Service, string.Format("{0}.Service", argName));
+
+ if (configuration.Interceptors != null)
+ {
+ IgniteArgumentCheck.Ensure(configuration.Interceptors.Count > 0,
Review Comment:
I think there is no reason for this restriction, it just makes the life harder for the users. There may be an edge case of some sorts on their side. Let's just treat null and empty the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r921342159
##########
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/PlatformTestServiceInterceptor.cs:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Tests.Services
+{
+ using System;
+ using Apache.Ignite.Core.Services;
+
+ /** Test service call interceptor. */
+ [Serializable]
Review Comment:
Not necessary, let's remove.
##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -66,6 +69,12 @@ public class ServiceConfiguration
/// </summary>
public IClusterNodeFilter NodeFilter { get; set; }
+ /// <summary>
+ /// Gets or sets service call interceptors.
+ /// </summary>
+ [IgniteExperimental]
+ public IReadOnlyCollection<IServiceCallInterceptor> Interceptors { get; set; }
Review Comment:
```suggestion
public ICollection<IServiceCallInterceptor> Interceptors { get; set; }
```
1. Consistent with other configuration APIs.
2. No need for read-only here.
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/CompositeServiceCallInterceptor.cs:
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Services
+{
+ using System;
+ using System.Collections.Generic;
+ using System.Diagnostics;
+ using Apache.Ignite.Core.Impl.Common;
+ using Apache.Ignite.Core.Services;
+
+ /// <summary>
+ /// Composite service call interceptor.
+ /// </summary>
+ /// <seealso cref="IServiceCallInterceptor"/>
+ [Serializable]
+ internal class CompositeServiceCallInterceptor : IServiceCallInterceptor
+ {
+ // Service call interceptors.
+ private readonly IEnumerable<IServiceCallInterceptor> _interceptors;
Review Comment:
```suggestion
private readonly ICollection<IServiceCallInterceptor> _interceptors;
```
`IEnumerable` may be lazily evaluated. To make the intent cleaner, let's require `ICollection` in constructor and store it this way.
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs:
##########
@@ -1021,18 +1022,21 @@ private long ServiceInit(long memPtr)
var srvKeepBinary = reader.ReadBoolean();
var svc = reader.ReadObject<IService>();
+ var interceptors = reader.ReadCollection();
Review Comment:
```suggestion
var interceptors = reader.ReadCollectionAsList<IServiceCallInterceptor>();
```
##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
w.WriteObject(NodeFilter);
else
w.WriteObject<object>(null);
+
+ if (Interceptors != null)
+ w.WriteCollection(Interceptors as ICollection);
+ else
+ w.WriteObject<object>(null);;
Review Comment:
```suggestion
w.WriteObject<object>(null);
```
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs:
##########
@@ -1051,22 +1055,37 @@ private long ServiceInit(long memPtr)
}
}
+ /// <summary>
+ /// Wraps a collection of interceptors into a composite interceptor.
+ /// </summary>
+ /// <param name="interceptors">Service call interceptors.</param>
+ /// <returns>Composite service call interceptor or null.</returns>
+ private IServiceCallInterceptor WrapInterceptors(ICollection interceptors)
Review Comment:
```suggestion
private IServiceCallInterceptor WrapInterceptors(IList<IServiceCallInterceptor> interceptors)
```
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/CompositeServiceCallInterceptor.cs:
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Services
+{
+ using System;
+ using System.Collections.Generic;
+ using System.Diagnostics;
+ using Apache.Ignite.Core.Impl.Common;
+ using Apache.Ignite.Core.Services;
+
+ /// <summary>
+ /// Composite service call interceptor.
+ /// </summary>
+ /// <seealso cref="IServiceCallInterceptor"/>
+ [Serializable]
Review Comment:
Not necessary, please remove.
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Unmanaged/UnmanagedCallbacks.cs:
##########
@@ -1051,22 +1055,37 @@ private long ServiceInit(long memPtr)
}
}
+ /// <summary>
+ /// Wraps a collection of interceptors into a composite interceptor.
+ /// </summary>
+ /// <param name="interceptors">Service call interceptors.</param>
+ /// <returns>Composite service call interceptor or null.</returns>
+ private IServiceCallInterceptor WrapInterceptors(ICollection interceptors)
+ {
+ if (interceptors == null)
+ return null;
+
+ // Inject Ignite instance resource.
+ foreach (var interceptor in interceptors)
+ ResourceProcessor.Inject(interceptor, _ignite);
+
+ // Wrap into a composite interceptor if necessary.
+ return interceptors.Count == 1 ? interceptors.OfType<IServiceCallInterceptor>().First() :
+ new CompositeServiceCallInterceptor(interceptors.OfType<IServiceCallInterceptor>());
Review Comment:
```suggestion
return interceptors.Count == 1 ? interceptors[0] : new CompositeServiceCallInterceptor(interceptors);
```
##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
w.WriteObject(NodeFilter);
else
w.WriteObject<object>(null);
+
+ if (Interceptors != null)
+ w.WriteCollection(Interceptors as ICollection);
Review Comment:
This cast can return null when, because `ICollection<T>` does not inherit from `ICollection`.
Let's add a generic overload for `WriteCollection` to avoid this cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r921949033
##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
w.WriteObject(NodeFilter);
else
w.WriteObject<object>(null);
+
+ if (Interceptors != null)
+ w.WriteCollection(Interceptors as ICollection);
Review Comment:
@ptupitsyn, maybe i can just use writeObject/readObject instead of writeCollection/readCollection/etc? (It seems to work fine)
I can't figure out how to add the suggested overload without duplicating code or converting from a generic collection to a non-generic one in BinaryWriter/BinaryUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922250624
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/Services.cs:
##########
@@ -501,6 +501,16 @@ private static void ValidateConfiguration(ServiceConfiguration configuration, st
IgniteArgumentCheck.NotNull(configuration, argName);
IgniteArgumentCheck.NotNullOrEmpty(configuration.Name, string.Format("{0}.Name", argName));
IgniteArgumentCheck.NotNull(configuration.Service, string.Format("{0}.Service", argName));
+
+ if (configuration.Interceptors != null)
+ {
+ IgniteArgumentCheck.Ensure(configuration.Interceptors.Count > 0,
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922198400
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformAbstractService.java:
##########
@@ -240,11 +243,13 @@ public void setIgniteInstance(Ignite ignite) {
@Override public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
svc = in.readObject();
srvKeepBinary = in.readBoolean();
+ interceptors = in.readObject();
Review Comment:
This will fail if we deserialize an old version of this class (from a node with older Ignite version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r921949033
##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
w.WriteObject(NodeFilter);
else
w.WriteObject<object>(null);
+
+ if (Interceptors != null)
+ w.WriteCollection(Interceptors as ICollection);
Review Comment:
@ptupitsyn, maybe i can just use writeObject/readObject instead of writeCollection/readCollection/etc? (It seems to work fine)
I can't figure out how to add the suggested overload without duplicating code or converting from a generic collection to a non-generic in BinaryWriter/BinaryUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922234623
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/LazyServiceConfiguration.java:
##########
@@ -143,7 +142,7 @@ public byte[] interceptorBytes() {
if (name != null ? !name.equals(that.getName()) : that.getName() != null)
return false;
- if (!F.eq(srvcClsName, that.srvcClsName))
+ if (!Arrays.equals(srvcBytes, that.srvcBytes))
Review Comment:
For example we have deployed a service with the name Service and the class Service.class.
If the user calls deploy again with the same service name, we compare the current service configuration with the deployed one.
If it matches, we do nothing and logging that the service has already been deployed.
If it does not match, we throwing an exception display to the user that it does not match.
Comparing the class name in this case is not entirely correct - because we can deploy a service with the same class name, but with a different state (let's say the service has a serializable flag that regulates its behavior).
In addition, for a .NET service, we will always have the same class name.
The test TestServiceCallInterceptorDeploy shows the issue that is fixed by this change (changing interceptor configuration and trying to deploy service with the same name).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922137373
##########
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/PlatformTestServiceInterceptor.cs:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Tests.Services
+{
+ using System;
+ using Apache.Ignite.Core.Services;
+
+ /** Test service call interceptor. */
+ [Serializable]
Review Comment:
Done, thanks.
##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/CompositeServiceCallInterceptor.cs:
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Services
+{
+ using System;
+ using System.Collections.Generic;
+ using System.Diagnostics;
+ using Apache.Ignite.Core.Impl.Common;
+ using Apache.Ignite.Core.Services;
+
+ /// <summary>
+ /// Composite service call interceptor.
+ /// </summary>
+ /// <seealso cref="IServiceCallInterceptor"/>
+ [Serializable]
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.
Posted by GitBox <gi...@apache.org>.
xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r922208063
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformAbstractService.java:
##########
@@ -240,11 +243,13 @@ public void setIgniteInstance(Ignite ignite) {
@Override public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
svc = in.readObject();
srvKeepBinary = in.readBoolean();
+ interceptors = in.readObject();
Review Comment:
AFAIK, Ignite does not provide such type of compatibility (you can't run a cluster with different Ignite versions) - only thin client protocol and persistence provide backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] xtern merged pull request #10145: IGNITE-17296 .NET: Add service interceptors
Posted by GitBox <gi...@apache.org>.
xtern merged PR #10145:
URL: https://github.com/apache/ignite/pull/10145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org