Re: [PR] Refactor integration and system tests to remove Zookeeper, add group protocol parameter [kafka]

["mumrah (via GitHub)" <gi...@apache.org>]

mumrah commented on code in PR #17581:
URL: https://github.com/apache/kafka/pull/17581#discussion_r1825982916


##########
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##########
@@ -66,7 +66,7 @@ class ListOffsetsIntegrationTest extends KafkaServerTestHarness {
   }
 
   @ParameterizedTest
-  @ValueSource(strings = Array("zk", "kraft"))
+  @ValueSource(strings = Array("kraft"))
   def testListMaxTimestampWithEmptyLog(quorum: String): Unit = {

Review Comment:
   There are some shenanigans done in the base test classes regarding the `quorum` param. Until we remove the ZK bits from that test infra, I think we actually need the `quorum` param :-/ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org