You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@codehaus.org> on 2009/11/18 11:55:58 UTC

[jira] Created: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Rename containerConfigXML if it does not match context.xml
----------------------------------------------------------

                 Key: MWAR-213
                 URL: http://jira.codehaus.org/browse/MWAR-213
             Project: Maven 2.x WAR Plugin
          Issue Type: Improvement
    Affects Versions: 2.1-beta-1
         Environment: Maven 2.0.10, JDK6, XP SP3
            Reporter: Michael Osipov
            Priority: Critical


I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:

remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.

Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231960#action_231960 ] 

Dennis Lundberg commented on MWAR-213:
--------------------------------------

Here's a suggestion for a work-around until this issues can be solved.

Put our context.xml files in different directories which all contains a file named context.xml. So instead of doing
{code:xml}
<containerConfigXML>src/main/conf/remote-context.xml</containerConfigXML>
{code}
you'd do 
{code:xml}
<containerConfigXML>src/main/conf-remote/context.xml</containerConfigXML>
{code}


> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>            Priority: Critical
>         Attachments: MWAR-213.zip
>
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Tom (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=199918#action_199918 ] 

Tom commented on MWAR-213:
--------------------------

I can confirm this on:
* Apache Maven 2.2.1 (r801777; 2009-08-06 22:16:01+0300)
* Java version: 1.6.0_15
* OS name: "linux" version: "2.6.31-15-generic" arch: "amd64" Family: "unix"

Besides not working in profiles, it does not work in when put in build > plugins > plugin, too.

> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>            Priority: Critical
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MWAR-213:
---------------------------------

    Attachment: MWAR-213.zip

Confirmed with this sample project.

> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>            Priority: Critical
>         Attachments: MWAR-213.zip
>
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MWAR-213:
---------------------------------

    Priority: Major  (was: Critical)

With a functioning work-around, I'm lowering the priority from critical to major.

> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>         Attachments: MWAR-213.zip
>
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Michael Osipov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231961#action_231961 ] 

Michael Osipov commented on MWAR-213:
-------------------------------------

Dennis,

this is exactly what I did when the problem came up.

> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>            Priority: Critical
>         Attachments: MWAR-213.zip
>
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Michael Osipov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231874#action_231874 ] 

Michael Osipov commented on MWAR-213:
-------------------------------------

Dennis, your assumption is correct. "context.xml" is Tomcat-specific. Jetty handles this completely different (http://docs.codehaus.org/display/JETTY/ContextDeployer). However, I think that all app servers which use Tomcat as servlet container use the context.xml too. The param you suggest would be a whise step.

> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>            Priority: Critical
>         Attachments: MWAR-213.zip
>
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-213) Rename containerConfigXML if it does not match context.xml

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=231860#action_231860 ] 

Dennis Lundberg commented on MWAR-213:
--------------------------------------

Having thought some more about this, isn't "context.xml" a Tomcat specific name. IIRC there is no such thing in the Servlet spec. So the name of the file is different for different Servlet Containers. To accommodate your request we would need another parameter "containerConfigXMLOutputName", that can be set to "context.xml" for Tomcat specific projects. The default value should be to use the same name as the input, i.e. the current behavior.

> Rename containerConfigXML if it does not match context.xml
> ----------------------------------------------------------
>
>                 Key: MWAR-213
>                 URL: http://jira.codehaus.org/browse/MWAR-213
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>         Environment: Maven 2.0.10, JDK6, XP SP3
>            Reporter: Michael Osipov
>            Priority: Critical
>         Attachments: MWAR-213.zip
>
>
> I ran into some problems with this plugin in use with profiles. I deploy different context.xml files. So I made up some names like:
> remote-context.xml and set <containerConfigXML>src/main/conf/remote-context.xml			</containerConfigXML> but when I run the package phase the file is copied as is and is not renamed to context.xml. Which of course makes no sense without renaming.
> Files should be renamed if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira