[GitHub] [incubator-druid] pdeva edited a comment on issue #7486: regression: quantilesDoublesSketch returns null instead of empty array

[GitBox <gi...@apache.org>]

pdeva edited a comment on issue #7486: regression: quantilesDoublesSketch returns null instead of empty array 
URL: https://github.com/apache/incubator-druid/issues/7486#issuecomment-484996125
 
 
   My suggestion would be to return an empty array `[]` instead of `null`.
   
   With an empty array, all code that works on array continues working naturally and unmodified.
   Eg, methods like `.map()`, `.filter()` etc continue to work and handle the case of empty array.
   
   With `null` we have to put in special checks in code everywhere to check for null.
   
   >If null result is undesirable in Druid, it should be changed in the post-aggs.
   
   what is the right way to change null to empty array in post agg? i dont even know. could you please clarify.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org