[jira] [Commented] (HADOOP-6311) Add support for unix domain sockets to JNI libs

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13075987#comment-13075987 ] 

Todd Lipcon commented on HADOOP-6311:
-------------------------------------

To reply to a really old comment that I missed:

bq. Todd, have you considered simply providing a jar and c-library from( or is derived from) the the Android code and making it available for hadoop? This way one can track the bug fixes and improvements in original Andriod.

The issue is that Android is a giant monolithic project -- this code comes from its equivalent of the JDK runtime, so it doesn't have its own standalone .so file or jar. I could certainly take this patch and put it on my github (or cloudera's github) as a standalone Java library "junixsockets" or something. In the past, people have been skeptical of this kind of contribution and have preferred to have code pulled into Hadoop itself.

Taking the code out of Android and adapting it to our needs is also beneficial in that we can re-use other utility code we already have in Hadoop common. For example, the patch in-progress for trunk reuses the NativeIOException that was developed during the security work.

Regarding tracking bug fixes from Android, it's worth noting that in the nearly two years since this ticket was filed, there was only one very-minor bug fix in the Android code: http://android.git.kernel.org/?p=platform/frameworks/base.git;a=history;f=core/java/android/net/LocalSocket.java;h=3ee8a80e9968e0bf8c8c8b4d0ee3076476db4ec9;hb=HEAD

So, I don't really foresee major maintenance issues in duplicating the code.

> Add support for unix domain sockets to JNI libs
> -----------------------------------------------
>
>                 Key: HADOOP-6311
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6311
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: native
>    Affects Versions: 0.20.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: 6311-trunk-inprogress.txt, hadoop-6311.txt
>
>
> For HDFS-347 we need to use unix domain sockets. This JIRA is to include a library in common which adds a o.a.h.net.unix package based on the code from Android (apache 2 license)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira