[GitHub] jovany-wang commented on a change in pull request #63: fix error: the dir doc and changelog not found when run deploy.sh

[GitBox <gi...@apache.org>]

jovany-wang commented on a change in pull request #63: fix error: the dir doc and changelog not found when run deploy.sh
URL: https://github.com/apache/rocketmq-client-cpp/pull/63#discussion_r246446685
 
 

 ##########
 File path: deploy.sh
 ##########
 @@ -30,8 +30,8 @@ cp -rf ${CWD_DIR}/bin/*.a    ${DEPLOY_BUILD_HOME}/lib/
 cp -rf ${CWD_DIR}/bin/*.so   ${DEPLOY_BUILD_HOME}/lib/
 cp -rf ${CWD_DIR}/include    ${DEPLOY_BUILD_HOME}/
 cp -rf ${CWD_DIR}/example    ${DEPLOY_BUILD_HOME}/
-cp -rf ${CWD_DIR}/doc 	     ${DEPLOY_BUILD_HOME}/
-cp -rf ${CWD_DIR}/changelog  ${DEPLOY_BUILD_HOME}/
+#cp -rf ${CWD_DIR}/doc 	     ${DEPLOY_BUILD_HOME}/
+#cp -rf ${CWD_DIR}/changelog  ${DEPLOY_BUILD_HOME}/
 
 Review comment:
   Could you please tell the reason for commenting these lines?
   If the `${CWD_DIR}/doc` is not existed, I think we should fix the issue that `${CWD_DIR}/doc` could not be found instead of commenting these directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services