You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by SpacRocket <sp...@icloud.com.INVALID> on 2023/02/21 18:52:02 UTC

[DISCUSS] KIP-907: Add Boolean Serde to public interface

Hello Everyone,

I’d like to get a discussion going for KIP-907:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface
Which adds Boolean Serde to the public interface.

The KIP contains the details how I want to do this and what internal code I need to change.

Looking forward to the group’s feedback! :)

Kind regards
Jakub

Re: [DISCUSS] KIP-907: Add Boolean Serde to public interface

Posted by spacrocket <sp...@icloud.com.INVALID>.

Hello Matthias,

Thanks for looking into my first KIP. I’ve updated the confluence document and soon I will start voting.

Kind regards
Jakub

> On Feb 23, 2023, at 8:23 AM, Matthias J. Sax <mj...@apache.org> wrote:
> 
> Thanks for the KIP.
> 
> Overall LGMT.
> 
> One comment: Both `BooleanSerializer` and `BooleanDeserializer` are also new classes that are added and should be listed explicitly similar to `BooleanSerde` in the "Public Interfaces" section of the KIP.
> 
> 
> -Matthias
> 
> On 2/21/23 10:52 AM, SpacRocket wrote:
>> Hello Everyone,
>> I’d like to get a discussion going for KIP-907:
>> KIP-907: Add Boolean Serde to public interface - Apache Kafka - Apache Software Foundation <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> cwiki.apache.org <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> 	favicon.ico <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> Which adds Boolean Serde to the public interface.
>> The KIP contains the details how I want to do this and what internal code I need to change.
>> Looking forward to the group’s feedback! :)
>> Kind regards
>> Jakub

Re: [DISCUSS] KIP-907: Add Boolean Serde to public interface

Posted by SpacRocket <sp...@icloud.com.INVALID>.

Hello Matthias,

Thanks for looking into my KIP and for an advice. I’ve added BooleanSerializer and BooleanDeserializer to the Public Interfaces.

Kind regards
Jakub

> On Feb 23, 2023, at 8:23 AM, Matthias J. Sax <mj...@apache.org> wrote:
> 
> Thanks for the KIP.
> 
> Overall LGMT.
> 
> One comment: Both `BooleanSerializer` and `BooleanDeserializer` are also new classes that are added and should be listed explicitly similar to `BooleanSerde` in the "Public Interfaces" section of the KIP.
> 
> 
> -Matthias
> 
> On 2/21/23 10:52 AM, SpacRocket wrote:
>> Hello Everyone,
>> I’d like to get a discussion going for KIP-907:
>> KIP-907: Add Boolean Serde to public interface - Apache Kafka - Apache Software Foundation <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> cwiki.apache.org <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> 	favicon.ico <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
>> Which adds Boolean Serde to the public interface.
>> The KIP contains the details how I want to do this and what internal code I need to change.
>> Looking forward to the group’s feedback! :)
>> Kind regards
>> Jakub

Re: [DISCUSS] KIP-907: Add Boolean Serde to public interface

Posted by "Matthias J. Sax" <mj...@apache.org>.

Thanks for the KIP.

Overall LGMT.

One comment: Both `BooleanSerializer` and `BooleanDeserializer` are also 
new classes that are added and should be listed explicitly similar to 
`BooleanSerde` in the "Public Interfaces" section of the KIP.


-Matthias

On 2/21/23 10:52 AM, SpacRocket wrote:
> Hello Everyone,
> 
> I’d like to get a discussion going for KIP-907:
> KIP-907: Add Boolean Serde to public interface - Apache Kafka - Apache 
> Software Foundation 
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
> cwiki.apache.org 
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
> 	favicon.ico 
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
> 
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface>
> Which adds Boolean Serde to the public interface.
> 
> The KIP contains the details how I want to do this and what internal 
> code I need to change.
> 
> Looking forward to the group’s feedback! :)
> 
> Kind regards
> Jakub