You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/23 15:01:40 UTC
[GitHub] [lucene] rmuir opened a new issue, #11969: invert error-prone configuration to be allow-list vs deny-list
rmuir opened a new issue, #11969:
URL: https://github.com/apache/lucene/issues/11969
### Description
Currently the error-prone is a long list of disabled checks. The problem is that on upgrade, more checks get enabled and slip into our configuration. Because of this, our error-prone has become very slow. For example android-specific checks are enabled.
The error-prone performance seems to be linear to the number of checks. I think we should disable all checks, then only enable the ones we want (e.g. ones that are not duplicated with JDK or ECJ checks). With this approach, we may be able to enable error-prone checking by default.
behavior of `main`:
```
225.22 sec. compileTestJava
223.56 sec. compileJava
```
behavior of error-prone with all checks disabled:
```
76.24 sec. compileJava
64.06 sec. compileTestJava
```
behavior of error-prone with just 12 checks enabled:
```
84.49 sec. compileJava
72.10 sec. compileTestJava
```
For this issue, i'd like to simply "invert" the list to be a list of checks that are currently enabled. So it won't really change functionality, but instead we can more visibly see what we have turned on and then fix it in a later issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir closed issue #11969: invert error-prone configuration to be allow-list vs deny-list
Posted by GitBox <gi...@apache.org>.
rmuir closed issue #11969: invert error-prone configuration to be allow-list vs deny-list
URL: https://github.com/apache/lucene/issues/11969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org