[jira] [Work logged] (GOBBLIN-1479) MySQL Extractor does not respect zeroDateTime configurations

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1479?focusedWorklogId=614155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614155 ]

ASF GitHub Bot logged work on GOBBLIN-1479:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jun/21 18:14
            Start Date: 23/Jun/21 18:14
    Worklog Time Spent: 10m 
      Work Description: lchik opened a new pull request #3319:
URL: https://github.com/apache/gobblin/pull/3319


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1479
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   In MySQL Connector 8, calling ResultSet.getString(int) on a record with a zero timestamp
   returns the string "0000-00-00 00:00:00", even when the connection property
   `zeroDateTimeBehavior=CONVERT_TO_NULL` is set.
   This change is a workaround to return null for these timestamps when the property is set.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 614155)
    Remaining Estimate: 0h
            Time Spent: 10m

> MySQL Extractor does not respect zeroDateTime configurations
> ------------------------------------------------------------
>
>                 Key: GOBBLIN-1479
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1479
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When adding connectionUrl properties for zeroDateTime, it is not respected by the MySQL 8 connector as the timestamp is parsed as a String, thus returning the zero timestamp instead of the behavior denoted by the property.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)