You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/03 13:19:23 UTC
[GitHub] [mynewt-core] brianwyld opened a new pull request #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
brianwyld opened a new pull request #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223
The bsp_defs.h in a specific BSP can redefine the idle stack size without changing the core of mynewt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] mlaz commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
mlaz commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605268844
Ok, I looked at https://github.com/apache/mynewt-core/pull/2138. Still hard to find out exactly why do you need redefine idle task's stack size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-594075785
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] mlaz edited a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
mlaz edited a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605157241
I believe we should use a MYNEWT_VAL for this, instead of another header file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-593950983
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] mlaz removed a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
mlaz removed a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605159608
@wes3 @andrzej-kaczmarek @sjanc ^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] mlaz edited a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
mlaz edited a comment on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605157241
I believe we should use a MYNEWT_VAL for this, instead of the header file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] mlaz commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
mlaz commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605159608
@wes3 @andrzej-kaczmarek @sjanc ^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605181178
Hi this was my original PR method, adding a syscfg (as for the main task
stack size). However this was not approved... and the method of an include
suggested.
brian
envoyé depuis ma nuage
On Fri, 27 Mar 2020, 18:53 Miguel Azevedo, <no...@github.com> wrote:
> @wes3 <https://github.com/wes3> @andrzej-kaczmarek
> <https://github.com/andrzej-kaczmarek> @sjanc <https://github.com/sjanc> ^
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/mynewt-core/pull/2223#issuecomment-605159608>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMIHRIH7O7L7GXUC45VZJ6TRJTR2XANCNFSM4LAKKU5Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-593950983
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-604901306
Any chance of getting this PR in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-594069064
Ok. Seems like bsp/bsp_defs.h is not a 'standard' file in mynewt BSPs.
How about bsp/bsp.h?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
brianwyld commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605297403
The need is to have an ajustable size for the stack depending on the bsp,
as during low power entry/exit (which takes place in the idle task) it is
neccessary to run different code blocks to deinit/reinit the peripherals on
a specific board.
This can involve calling up to the bsp and/or app (see my other PR for the
method I propose to integrate this kind of system)
envoyé depuis ma nuage
On Fri, 27 Mar 2020, 20:30 Miguel Azevedo, <no...@github.com> wrote:
> Ok, I looked at #2138 <https://github.com/apache/mynewt-core/pull/2138>.
> Still hard to find out exactly why do you need redefine idle task's stack
> size.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/mynewt-core/pull/2223#issuecomment-605268844>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMIHRIHEOZOVLZHC2SJKBK3RJT5E7ANCNFSM4LAKKU5Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] mlaz commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
Posted by GitBox <gi...@apache.org>.
mlaz commented on issue #2223: add include of bsp_defs.h so that a BSP can override defines (for exa…
URL: https://github.com/apache/mynewt-core/pull/2223#issuecomment-605157241
I believe we should use a MYNEWT_VAL for this, instead of one more header file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services