[GitHub] [superset] Always-prog commented on a diff in pull request #23783: fix(datasource): saving new calculated columns

["Always-prog (via GitHub)" <gi...@apache.org>]

Always-prog commented on code in PR #23783:
URL: https://github.com/apache/superset/pull/23783#discussion_r1175588396


##########
superset-frontend/src/components/Datasource/DatasourceModal.tsx:
##########
@@ -139,7 +139,7 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
         ),
         columns: currentDatasource?.columns?.map(
           (column: Record<string, unknown>) => ({
-            id: column.id,
+            id: typeof column.id !== 'string' ? column.id : undefined,

Review Comment:
   I think so, let me fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org