You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by "Guangxu Cheng (Jira)" <ji...@apache.org> on 2020/02/16 13:21:00 UTC
[jira] [Assigned] (TUBEMQ-9) Unnecessary code
[ https://issues.apache.org/jira/browse/TUBEMQ-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guangxu Cheng reassigned TUBEMQ-9:
----------------------------------
Assignee: lan.liang
> Unnecessary code
> -----------------
>
> Key: TUBEMQ-9
> URL: https://issues.apache.org/jira/browse/TUBEMQ-9
> Project: Apache TubeMQ
> Issue Type: Improvement
> Reporter: lan.liang
> Assignee: lan.liang
> Priority: Minor
>
> 1. 'String.valueOf()'
> {noformat}
> String strCallbackFun = req.getParameter("callback");
> if ((TStringUtils.isNotEmpty(strCallbackFun))
> && (strCallbackFun.length() <= TBaseConstants.META_MAX_CALLBACK_STRING_LENGTH)
> && (strCallbackFun.matches(TBaseConstants.META_TMP_CALLBACK_STRING_VALUE))) {
> strCallbackFun = String.valueOf(strCallbackFun).trim();
> }{noformat}
>
> com.tencent.tubemq.server.master.web.action.screen.Webapi#execute
>
> 2. \{String}.substring()
> {noformat}
> if (path.startsWith("/")) {
> path = path.substring(1, path.length());
> }{noformat}
> com.tencent.tubemq.server.master.web.simplemvc.RequestContext#normalizePath
>
> 3.unuse init boolean
> {noformat}
> private boolean isOverTLS = false;
> {noformat}
> com.tencent.tubemq.corerpc.netty.NettyRpcServer isOverTLS
>
>
> PR [https://github.com/apache/incubator-tubemq/pull/3]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)