You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/18 05:54:36 UTC
[GitHub] [buildstream] gtristan opened a new pull request, #1725: _artifactcache/cascache.py: Check for permission denied when initiali…
gtristan opened a new pull request, #1725:
URL: https://github.com/apache/buildstream/pull/1725
…zing remote
When we check whether the remote supports PushDirectory() requests, we were
ignoring the possible permission denied.
These checks are made for compatibility with servers, some REAPI requests
are more efficient but not always supported, if they are not supported we
fallback to more inefficient codepaths. When checking push related APIs
we should also ignore errors related to lack of permission.
Fixes #1724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1725: _artifactcache/cascache.py: Only check push capabilities for push remotes
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1725:
URL: https://github.com/apache/buildstream/pull/1725#issuecomment-1219115804
> While this is a good thing to have, I think it doesn't fix #1724.
>
> In the case of #1724, we still have an HTTP 404 error which should map to UNIMPLEMENTED. For some reason (likely a bug in grpcio) it is being mapped to some other error (the "stream removed" thing)
I've updated the patch to additionally only check for these push capabilities on push remotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1725: _artifactcache/cascache.py: Only check push capabilities for push remotes
Posted by GitBox <gi...@apache.org>.
gtristan merged PR #1725:
URL: https://github.com/apache/buildstream/pull/1725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on pull request #1725: _artifactcache/cascache.py: Check for permission denied when initializing remote
Posted by GitBox <gi...@apache.org>.
abderrahim commented on PR #1725:
URL: https://github.com/apache/buildstream/pull/1725#issuecomment-1219101550
While this is a good thing to have, I think it doesn't fix #1724.
In the case of #1724, we still have an HTTP 404 error which should map to UNIMPLEMENTED. For some reason (likely a bug in grpcio) it is being mapped to some other error (the "stream removed" thing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org