You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/08/15 12:37:47 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #572: =act Extract AtomicCancellable in Scheduler.
He-Pin opened a new pull request, #572:
URL: https://github.com/apache/incubator-pekko/pull/572
Motivation:
Reduce code duplication and make the code simpler to understand.
Result:
Simpler Code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #572: =act Extract AtomicCancellable in Scheduler.
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #572:
URL: https://github.com/apache/incubator-pekko/pull/572#discussion_r1294583593
##########
actor/src/main/scala/org/apache/pekko/actor/LightArrayRevolverScheduler.scala:
##########
@@ -30,6 +30,8 @@ import pekko.event.LoggingAdapter
import pekko.util.Helpers
import pekko.util.Unsafe.{ instance => unsafe }
+import org.apache.pekko.actor.Scheduler.AtomicCancellable
Review Comment:
could you match the import style above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #572: Extract AtomicCancellable in Scheduler.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #572:
URL: https://github.com/apache/incubator-pekko/pull/572#issuecomment-1696886130
I have some offline pair view, too, from @WayneWang12 and @dengziming, so will be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #572: =act Extract AtomicCancellable in Scheduler.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #572:
URL: https://github.com/apache/incubator-pekko/pull/572#discussion_r1294647987
##########
actor/src/main/scala/org/apache/pekko/actor/LightArrayRevolverScheduler.scala:
##########
@@ -30,6 +30,8 @@ import pekko.event.LoggingAdapter
import pekko.util.Helpers
import pekko.util.Unsafe.{ instance => unsafe }
+import org.apache.pekko.actor.Scheduler.AtomicCancellable
Review Comment:
Can this be part of scalafmt, hum...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #572: Extract AtomicCancellable in Scheduler.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #572:
URL: https://github.com/apache/incubator-pekko/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org