You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/10 01:41:21 UTC

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-31936][SQL]Implement ScriptTransformation in sql/core

AngersZhuuuu commented on pull request #27983:
URL: https://github.com/apache/spark/pull/27983#issuecomment-641669177


   > I have not looked at details yet. Generally I think this PR includes both refactoring Hive ScriptTransformation and adding ScriptTransformation in sql/core. Maybe we can refactor it first and add ScriptTransformation in sql/core later.
   
   There are some problem in current ScriptTransformation:
   
    1.  support use transform with aggregation [SPARK-28227](https://issues.apache.org/jira/browse/SPARK-28227)
    2. support array/map as transform's input [SPARK-22435](https://issues.apache.org/jira/browse/SPARK-22435)
    3. Handle DateType/TimestampType un correctly.
   
   In pr https://issues.apache.org/jira/browse/SPARK-28227 , I was suggest to implement in sql/core first.  In my opinion,  both way is clear if we design this part well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org