[GitHub] [airflow] eladkal commented on issue #5558: [AIRFLOW-4136] fix key_file of SSHHook to be overwritten by connection

[GitBox <gi...@apache.org>]

eladkal commented on issue #5558: [AIRFLOW-4136] fix key_file of SSHHook to be overwritten by connection
URL: https://github.com/apache/airflow/pull/5558#issuecomment-510565640
 
 
   @XD-DENG 
   
   Airflow always gives priority to settings passed to hook upon default of Connection.
   It's very practical as this allows you to overwrite default.
   For example if you specified schema in connection you want to allow users to overwrite the schema in the hook so they will be able to interact with other schema in the database. This is not different than what this PR is trying to fix.
   Examples for priority of hook upon connections from:
   https://github.com/apache/airflow/blob/master/airflow/hooks/hive_hooks.py#L101
   https://github.com/apache/airflow/blob/master/airflow/hooks/mysql_hook.py#L78
   
   PR https://github.com/apache/airflow/pull/5155 which attempted to fix the issue actually did the opposite thing. It ignored the parameter passed to the hook and gave priority to the Connection.
   Since the fix to https://issues.apache.org/jira/browse/AIRFLOW-4136 was not yet released I don't think we need to update ` Update.md`
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services