[GitHub] [arrow-datafusion] andygrove commented on issue #3794: When DataFusion optimizer rewrites an expression, it should not change the expressions "name" / "identity" / "alias"

[GitBox <gi...@apache.org>]

andygrove commented on issue #3794:
URL: https://github.com/apache/arrow-datafusion/issues/3794#issuecomment-1274662465

   There are currently two ways to create a "name" for an expression in the logical plan.
   
   ```
       /// Returns the name of this expression as it should appear in a schema. This name
       /// will not include any CAST expressions.
       pub fn name(&self) -> Result<String> {
           create_name(self)
       }
   
       /// Returns a full and complete string representation of this expression.
       pub fn canonical_name(&self) -> String {
           format!("{}", self)
       }
   ```
   
   I have seen that we sometimes use `name` when we should use `canonical_name` instead. 
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org