You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Nicolas Toper (JIRA)" <ji...@apache.org> on 2006/07/28 21:41:14 UTC
[jira] Created: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
---------------------------------------------------------------------------
Key: JCR-521
URL: http://issues.apache.org/jira/browse/JCR-521
Project: Jackrabbit
Issue Type: Improvement
Components: core
Reporter: Nicolas Toper
Priority: Trivial
As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Nicolas Toper (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=all ]
Nicolas Toper updated JCR-521:
------------------------------
Attachment: patch-060728-3.txt
Correcting A and B
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: New Feature
> Components: nodetype
> Reporter: Nicolas Toper
> Assigned To: Jukka Zitting
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: patch-060728-3.txt, patch060728-2.txt, patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Nicolas Toper (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=all ]
Nicolas Toper updated JCR-521:
------------------------------
Attachment: patch060728.txt
Here is the patch implementing those changes.
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: Improvement
> Components: core
> Reporter: Nicolas Toper
> Priority: Trivial
> Attachments: patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Nicolas Toper (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=all ]
Nicolas Toper closed JCR-521.
-----------------------------
I think this issue is now closed :)
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: New Feature
> Components: nodetype
> Reporter: Nicolas Toper
> Assigned To: Jukka Zitting
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: patch-060728-3.txt, patch060728-2.txt, patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Nicolas Toper (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=all ]
Nicolas Toper updated JCR-521:
------------------------------
Attachment: patch060728-2.txt
Sure. Here it is.
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: New Feature
> Components: nodetype
> Reporter: Nicolas Toper
> Assigned To: Jukka Zitting
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: patch060728-2.txt, patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=all ]
Jukka Zitting resolved JCR-521.
-------------------------------
Resolution: Fixed
Thanks for the updates.
Committed with minor modifications in revision 426682.
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: New Feature
> Components: nodetype
> Reporter: Nicolas Toper
> Assigned To: Jukka Zitting
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: patch-060728-3.txt, patch060728-2.txt, patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=comments#action_12424180 ]
Jukka Zitting commented on JCR-521:
-----------------------------------
Two stylistic issues still. (I'm probably more strict with you than with a random contributor, but please bear with me. :-)
a) Using "this." is usually redundant in normal method calls, unless you explicitly want to draw attention to the fact that a method is invoked on "this".
b) There are two extra empty lines being added by your patch. While they do no harm, it is generally a good practice to trim any unnecessary modifications out of your patches before submitting them. Less clutter makes it easier to review the patch.
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: New Feature
> Components: nodetype
> Reporter: Nicolas Toper
> Assigned To: Jukka Zitting
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: patch060728-2.txt, patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-521) Add a method public boolean
hasNodeType(String name) in NodeTypeManagerImpl
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-521?page=all ]
Jukka Zitting updated JCR-521:
------------------------------
Component/s: nodetype
(was: core)
Issue Type: New Feature (was: Improvement)
Fix Version/s: 1.1
Assignee: Jukka Zitting
Thanks! One point though, could you catch the internal NameExceptions in the method and
convert them to RepositoryExceptions for symmetry with the JCR API methods? The interfaces
in o.a.j.api should have no dependencies outside J2SE and JCR.
> Add a method public boolean hasNodeType(String name) in NodeTypeManagerImpl
> ---------------------------------------------------------------------------
>
> Key: JCR-521
> URL: http://issues.apache.org/jira/browse/JCR-521
> Project: Jackrabbit
> Issue Type: New Feature
> Components: nodetype
> Reporter: Nicolas Toper
> Assigned To: Jukka Zitting
> Priority: Trivial
> Fix For: 1.1
>
> Attachments: patch060728.txt
>
>
> As seen in the ML, we plan to add this method and update this class and the interface JackrabbitNodeTypeManager
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira