You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/07 19:28:18 UTC

[jira] [Commented] (NUMBERS-40) Review exception usage in package "o.a.c.numbers.gamma"

    [ https://issues.apache.org/jira/browse/NUMBERS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041474#comment-16041474 ] 

ASF GitHub Bot commented on NUMBERS-40:
---------------------------------------

GitHub user tharakadesilva opened a pull request:

    https://github.com/apache/commons-numbers/pull/6

    NUMBERS-40

    Modified "GammaException" to be a subclass of "ArithmeticException" instead of "IllegalArgumentException".
    Modified the test assertions to expect for "GammaException"s instead of "IllegalArgumentException"s.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tharakadesilva/commons-numbers desilva/develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-numbers/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 813c6707ea0d47c78fc25ca79f6df990e6b8bf67
Author: Tharaka De Silva <th...@gmail.com>
Date:   2017-06-07T19:21:23Z

    modified GammaException to be a part of ArithmeticException instead of IllegalArgumentException

commit aadb0f0962a76264c7d8607453f6495e432a89d5
Author: Tharaka De Silva <th...@gmail.com>
Date:   2017-06-07T19:25:01Z

    modified the test assertions to assert for the GammaException

----


> Review exception usage in package "o.a.c.numbers.gamma"
> -------------------------------------------------------
>
>                 Key: NUMBERS-40
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-40
>             Project: Commons Numbers
>          Issue Type: Bug
>            Reporter: Gilles
>              Labels: exception
>             Fix For: 1.0
>
>
> Exceptions raised should have a consistent type ({{ArithmeticException}} vs {{IllegalArgumentException}}).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)