You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/21 04:53:19 UTC
[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/2045
[ZEPPELIN-2112] Disable keyboard shortcut in "Link this paragraph" URL on 0.7.0 version
### What is this PR for?
If using a `Link this paragraph`, new window works the keyboard shortcut on the 0.7.0 version.
So that this is the keyboard shortcut should not work in `Link this paragraph` URL on branch-0.7.
Also, I remove border and margin of paragraph in new window of "Link this paragraph". this would be more useful.
This issue is related to [ZEPPELIN-1808](https://issues.apache.org/jira/browse/ZEPPELIN-1808) and this [comment](https://github.com/apache/zeppelin/pull/1983#issuecomment-279395050) suggestion by @Leemoonsoo.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [x] - Disable keyboard shortcut in new window of "Link this paragraph" on 0.7.0 version
* [x] - Fix layout about border and margin in paragraph website
### What is the Jira issue?
* [ZEPPELIN-2112](https://issues.apache.org/jira/browse/ZEPPELIN-2112)
### How should this be tested?
1. Build `branch-0.7` branch and run Zeppelin
2. Click `Link this paragraph` or Use Ctrl+Alt(command)+w in a paragraph.
3. Use some keyboard shortcut in new window which is created by `Link this paragraph`.
4. Check text and title shape of the paragraph such like text, title, graph.. etc.
### Screenshots (if appropriate)
[ Before ]
[ After ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin 0.7-ZEPPELIN-2112_dont_shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2045
----
commit af06b67127383db8c0d374a7794638fa75131f58
Author: soralee <so...@zepl.com>
Date: 2017-02-21T03:11:18Z
disable shortcut key in Link this paragraph url
commit 31b7551af2f52951eac65f59f9c19b09a8375175
Author: soralee <so...@zepl.com>
Date: 2017-02-21T03:18:24Z
revort file
commit 4697b9432151a616c11ccdbc6a0fe20186e74ddc
Author: soralee <so...@zepl.com>
Date: 2017-02-21T03:19:13Z
revort file
commit 27e6d29246c62a0a5f0e662de78871c1e6fdf3a6
Author: soralee <so...@zepl.com>
Date: 2017-02-21T04:15:58Z
remove left space
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "Link thi...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2045
@Leemoonsoo Sure, I'll close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "Link thi...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2045
Ping! @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "Link thi...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2045
Tested and LGTM.
Merge to branch-0.7 if no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/2045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "Link thi...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2045
@soralee I merged this PR to `branch-0.7`. But somehow this PR can not be closed by `asfgit`. Can you close this PR manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/2045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/2045
[ZEPPELIN-2112] Disable keyboard shortcut in "Link this paragraph" URL on 0.7.0 version
### What is this PR for?
If using a `Link this paragraph`, new window works the keyboard shortcut on the 0.7.0 version.
So that this is the keyboard shortcut should not work in `Link this paragraph` URL on branch-0.7.
Also, I remove border and margin of paragraph in new window of "Link this paragraph". this would be more useful.
This issue is related to [ZEPPELIN-1808](https://issues.apache.org/jira/browse/ZEPPELIN-1808) and this [comment](https://github.com/apache/zeppelin/pull/1983#issuecomment-279395050) suggestion by @Leemoonsoo.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [x] - Disable keyboard shortcut in new window of "Link this paragraph" on 0.7.0 version
* [x] - Fix layout about border and margin in paragraph website
### What is the Jira issue?
* [ZEPPELIN-2112](https://issues.apache.org/jira/browse/ZEPPELIN-2112)
### How should this be tested?
1. Build `branch-0.7` branch and run Zeppelin
2. Click `Link this paragraph` or Use Ctrl+Alt(command)+w in a paragraph.
3. Use some keyboard shortcut in new window which is created by `Link this paragraph`.
4. Check text and title shape of the paragraph such like text, title, graph.. etc.
### Screenshots (if appropriate)
[ Before ]
[ After ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin 0.7-ZEPPELIN-2112_dont_shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2045
----
commit af06b67127383db8c0d374a7794638fa75131f58
Author: soralee <so...@zepl.com>
Date: 2017-02-21T03:11:18Z
disable shortcut key in Link this paragraph url
commit 31b7551af2f52951eac65f59f9c19b09a8375175
Author: soralee <so...@zepl.com>
Date: 2017-02-21T03:18:24Z
revort file
commit 4697b9432151a616c11ccdbc6a0fe20186e74ddc
Author: soralee <so...@zepl.com>
Date: 2017-02-21T03:19:13Z
revort file
commit 27e6d29246c62a0a5f0e662de78871c1e6fdf3a6
Author: soralee <so...@zepl.com>
Date: 2017-02-21T04:15:58Z
remove left space
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---