You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Qiao Wang <yq...@cn.ibm.com> on 2015/10/21 15:19:56 UTC
Review Request 39516: Slave should accept PingSlaveMessage but not
"PING" message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39516/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1832
https://issues.apache.org/jira/browse/MESOS-1832
Repository: mesos
Description
-------
Slave should accept PingSlaveMessage but not "PING" message.
Diffs
-----
src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa
src/slave/slave.hpp 04a8646bce53adaaeb6e06ea65bb82e1f1da91e0
src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
Diff: https://reviews.apache.org/r/39516/diff/
Testing
-------
Make Successfully;
Make check Successfully;
Thanks,
Yong Qiao Wang
Re: Review Request 39516: Slave should accept PingSlaveMessage but not
"PING" message.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39516/#review103411
-----------------------------------------------------------
src/slave/slave.hpp (line 186)
<https://reviews.apache.org/r/39516/#comment161469>
Is this comment still relevant?
- Neil Conway
On Oct. 21, 2015, 1:19 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39516/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 1:19 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1832
> https://issues.apache.org/jira/browse/MESOS-1832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Slave should accept PingSlaveMessage but not "PING" message.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa
> src/slave/slave.hpp 04a8646bce53adaaeb6e06ea65bb82e1f1da91e0
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39516/diff/
>
>
> Testing
> -------
>
> Make Successfully;
> Make check Successfully;
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 39516: Slave should accept PingSlaveMessage but not
"PING" message.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39516/#review103401
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39516]
All tests passed.
- Mesos ReviewBot
On Oct. 21, 2015, 1:19 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39516/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 1:19 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1832
> https://issues.apache.org/jira/browse/MESOS-1832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Slave should accept PingSlaveMessage but not "PING" message.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa
> src/slave/slave.hpp 04a8646bce53adaaeb6e06ea65bb82e1f1da91e0
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39516/diff/
>
>
> Testing
> -------
>
> Make Successfully;
> Make check Successfully;
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 39516: Slave should accept PingSlaveMessage but not
"PING" message.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39516/#review103452
-----------------------------------------------------------
Ship it!
src/slave/slave.hpp (line 186)
<https://reviews.apache.org/r/39516/#comment161515>
i'll remove this comment when committing.
- Vinod Kone
On Oct. 21, 2015, 1:19 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39516/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 1:19 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1832
> https://issues.apache.org/jira/browse/MESOS-1832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Slave should accept PingSlaveMessage but not "PING" message.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa
> src/slave/slave.hpp 04a8646bce53adaaeb6e06ea65bb82e1f1da91e0
> src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3
>
> Diff: https://reviews.apache.org/r/39516/diff/
>
>
> Testing
> -------
>
> Make Successfully;
> Make check Successfully;
>
>
> Thanks,
>
> Yong Qiao Wang
>
>