[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #44: Export init args to environment.

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44#discussion_r544707932



##########
File path: core/dotnet3.1/proxy/Apache.OpenWhisk.Runtime.Common/Init.cs
##########
@@ -120,6 +121,17 @@ public async Task<Run> HandleRequest(HttpContext httpContext)
 
                 try
                 {
+                    // Export init arguments as environment variables
+                    if (message["env"] != null && message["env"].HasValues)

Review comment:
       @shawnallen85 this is to avoid null exceptions when the env is a "null" json value.
   I opted to put the code here instead of earlier to let the quicker failures to come first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org