You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/12 09:56:19 UTC
[GitHub] [airflow] mcepok opened a new pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
mcepok opened a new pull request #14740:
URL: https://github.com/apache/airflow/pull/14740
`airflow upgrade` check exits with code 1, even if there are no problem. If I understand https://github.com/apache/airflow/blob/995e4b9ba4bffed9f3b721b52592257ea7752b72/airflow/upgrade/checker.py#L118-L120 correctly, as long as any check is performed, it will always exit with code 1.
I extended the `Rule` object by an `is_problem` property and replace the current check _if there are any Rules_ by _if there are any problems_, where a skipped Rule doesn't count as a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14740:
URL: https://github.com/apache/airflow/pull/14740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14740:
URL: https://github.com/apache/airflow/pull/14740#issuecomment-797399272
[The Workflow run](https://github.com/apache/airflow/actions/runs/645832658) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14740:
URL: https://github.com/apache/airflow/pull/14740#issuecomment-797392053
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #14740:
URL: https://github.com/apache/airflow/pull/14740#discussion_r593057747
##########
File path: airflow/upgrade/checker.py
##########
@@ -115,8 +115,9 @@ def run(args):
# We want to show only output of upgrade_check command
logging.disable(logging.ERROR)
- all_problems = check_upgrade(formatter, rules)
- if all_problems:
+ all_rule_statuses = check_upgrade(formatter, rules)
+ any_problems = any([rule.is_problem for rule in all_rule_statuses])
Review comment:
```suggestion
any_problems = any(rule.is_problem for rule in all_rule_statuses)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcepok commented on a change in pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
Posted by GitBox <gi...@apache.org>.
mcepok commented on a change in pull request #14740:
URL: https://github.com/apache/airflow/pull/14740#discussion_r593060708
##########
File path: airflow/upgrade/checker.py
##########
@@ -115,8 +115,9 @@ def run(args):
# We want to show only output of upgrade_check command
logging.disable(logging.ERROR)
- all_problems = check_upgrade(formatter, rules)
- if all_problems:
+ all_rule_statuses = check_upgrade(formatter, rules)
+ any_problems = any([rule.is_problem for rule in all_rule_statuses])
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14740: Don't exit upgrade_check with code 1 if there are no problems
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14740:
URL: https://github.com/apache/airflow/pull/14740#issuecomment-797501286
Thanks for the review @uranusjr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org