You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@spamassassin.apache.org by he...@apache.org on 2022/05/05 17:48:30 UTC

svn commit: r1900597 - /spamassassin/trunk/t/mkrules_else.t

Author: hege
Date: Thu May  5 17:48:29 2022
New Revision: 1900597

URL: http://svn.apache.org/viewvc?rev=1900597&view=rev
Log:
Fix spurious cannot open mkrules_else.0 warnings

Modified:
    spamassassin/trunk/t/mkrules_else.t

Modified: spamassassin/trunk/t/mkrules_else.t
URL: http://svn.apache.org/viewvc/spamassassin/trunk/t/mkrules_else.t?rev=1900597&r1=1900596&r2=1900597&view=diff
==============================================================================
--- spamassassin/trunk/t/mkrules_else.t (original)
+++ spamassassin/trunk/t/mkrules_else.t Thu May  5 17:48:29 2022
@@ -175,7 +175,8 @@ sub mkrun {
   untaint_system ("$scrargs > $workdir/$testname.$test_number $post_redir");
   $mk_exitcode = ($?>>8);
   if ($mk_exitcode != 0) { return undef; }
-  &checkfile ("$testname.$test_number", $read_sub) if (defined $read_sub);
+  # apparently redundant check, complains cannot open mkrules_else.0
+  #&checkfile ("$testname.$test_number", $read_sub) if (defined $read_sub);
   1;
 }

Re: svn commit: r1900597 - /spamassassin/trunk/t/mkrules_else.t

Posted by Sidney Markowitz <si...@sidney.com>.

Thanks, Henrik for this and the other little test things. They were 
bothering me every time I ran tests the past few days while working on 
the big test issues, but I had to put off fixing them.

Isn't nice when tests produce so little noise that you can finally see 
the cosmetic or little problems and fix them?

hege@apache.org wrote on 6/05/22 5:48 am:
> Author: hege
> Date: Thu May  5 17:48:29 2022
> New Revision: 1900597
> 
> URL: http://svn.apache.org/viewvc?rev=1900597&view=rev
> Log:
> Fix spurious cannot open mkrules_else.0 warnings
> 
> Modified:
>      spamassassin/trunk/t/mkrules_else.t