You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (JIRA)" <ji...@apache.org> on 2011/09/08 20:54:09 UTC
[jira] [Created] (ZOOKEEPER-1175) DataNode references parent node
for no reason
DataNode references parent node for no reason
---------------------------------------------
Key: ZOOKEEPER-1175
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
Project: ZooKeeper
Issue Type: Improvement
Reporter: Thomas Koch
Assignee: Thomas Koch
Priority: Minor
Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100591#comment-13100591 ]
Hadoop QA commented on ZOOKEEPER-1175:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12493641/ZOOKEEPER-1175.patch
against trunk revision 1165443.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/513//testReport/
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/513//console
This message is automatically generated.
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105270#comment-13105270 ]
Hudson commented on ZOOKEEPER-1175:
-----------------------------------
Integrated in ZooKeeper-trunk #1304 (See [https://builds.apache.org/job/ZooKeeper-trunk/1304/])
ZOOKEEPER-1175. DataNode references parent node for no reason (Thomas Koch via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170886
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1175.patch, ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1175:
-----------------------------------
Attachment: ZOOKEEPER-1175.patch
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1175:
-----------------------------------
Attachment: ZOOKEEPER-1175.patch
Didn't see one reference to DateNode.parent in UpgradeSnapShotV1.java.
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch, ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100582#comment-13100582 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1175:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1758/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104935#comment-13104935 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1175:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1758/
-----------------------------------------------------------
(Updated 2011-09-14 22:17:46.389383)
Review request for zookeeper.
Summary (updated)
-------
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch, ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100602#comment-13100602 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1175:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1758/
-----------------------------------------------------------
(Updated 2011-09-08 19:15:37.067342)
Review request for zookeeper.
Changes
-------
Didn't see one reference to DateNode.parent in UpgradeSnapShotV1.java.
Summary
-------
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch, ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1175) DataNode references parent node
for no reason
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100634#comment-13100634 ]
Hadoop QA commented on ZOOKEEPER-1175:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12493645/ZOOKEEPER-1175.patch
against trunk revision 1165443.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/514//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/514//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/514//console
This message is automatically generated.
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch, ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it needs to be. With the parent you need to get the parent before you can create the DataNode. Without the parent in the DataNode one can have a method tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira