You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Flavio Percoco <fl...@gmail.com> on 2015/06/16 09:46:04 UTC

Review Request 35497: PROTON-895: errno is part of `os`

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35497/
-----------------------------------------------------------

Review request for qpid and Kenneth Giusti.


Repository: qpid-proton-git


Description
-------

PROTON-895: errno is part of `os`


Diffs
-----

  proton-c/bindings/python/setuputils/misc.py cf6b97f041baf02371cd6847be6506ea81a5e412 

Diff: https://reviews.apache.org/r/35497/diff/


Testing
-------


Thanks,

Flavio Percoco

Re: Review Request 35497: PROTON-895: errno is part of `os`

Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35497/#review88066
-----------------------------------------------------------



proton-c/bindings/python/setuputils/misc.py (line 43)
<https://reviews.apache.org/r/35497/#comment140479>

    this works, but isn't errno a top level builtin?
    
    os.errno doesn't appear in the python docs
    
    can't the patch simply import errno instead?


- Kenneth Giusti


On June 16, 2015, 7:46 a.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35497/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 7:46 a.m.)
> 
> 
> Review request for qpid and Kenneth Giusti.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> PROTON-895: errno is part of `os`
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/python/setuputils/misc.py cf6b97f041baf02371cd6847be6506ea81a5e412 
> 
> Diff: https://reviews.apache.org/r/35497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>

Re: Review Request 35497: PROTON-895: errno is part of `os`

Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35497/#review88069
-----------------------------------------------------------

Ship it!


Ship It!

- Kenneth Giusti


On June 16, 2015, 3:31 p.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35497/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 3:31 p.m.)
> 
> 
> Review request for qpid and Kenneth Giusti.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> PROTON-895: errno is part of `os`
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/python/setuputils/misc.py cf6b97f041baf02371cd6847be6506ea81a5e412 
> 
> Diff: https://reviews.apache.org/r/35497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>

Re: Review Request 35497: PROTON-895: errno is part of `os`

Posted by Flavio Percoco <fl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35497/
-----------------------------------------------------------

(Updated June 16, 2015, 4:02 p.m.)


Review request for qpid and Kenneth Giusti.


Repository: qpid-proton-git


Description
-------

PROTON-895: errno is part of `os`


Diffs (updated)
-----

  proton-c/bindings/python/setuputils/misc.py cf6b97f 

Diff: https://reviews.apache.org/r/35497/diff/


Testing
-------


Thanks,

Flavio Percoco

Re: Review Request 35497: PROTON-895: errno is part of `os`

Posted by Flavio Percoco <fl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35497/
-----------------------------------------------------------

(Updated June 16, 2015, 3:31 p.m.)


Review request for qpid and Kenneth Giusti.


Repository: qpid-proton-git


Description
-------

PROTON-895: errno is part of `os`


Diffs (updated)
-----

  proton-c/bindings/python/setuputils/misc.py cf6b97f041baf02371cd6847be6506ea81a5e412 

Diff: https://reviews.apache.org/r/35497/diff/


Testing
-------


Thanks,

Flavio Percoco

Re: Review Request 35497: PROTON-895: errno is part of `os`

Posted by Flavio Percoco <fl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35497/
-----------------------------------------------------------

(Updated June 16, 2015, 3:25 p.m.)


Review request for qpid and Kenneth Giusti.


Changes
-------

addressed Ken's comments. it now imports `errno`


Repository: qpid-proton-git


Description
-------

PROTON-895: errno is part of `os`


Diffs (updated)
-----

  proton-c/bindings/python/setuputils/misc.py cf6b97f041baf02371cd6847be6506ea81a5e412 

Diff: https://reviews.apache.org/r/35497/diff/


Testing
-------


Thanks,

Flavio Percoco