You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/08 02:09:10 UTC
[jira] [Commented] (TINKERPOP3-886) Allow any GraphReader/Writer to
be persistence engine for TinkerGraph
[ https://issues.apache.org/jira/browse/TINKERPOP3-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995477#comment-14995477 ]
ASF GitHub Bot commented on TINKERPOP3-886:
-------------------------------------------
GitHub user kushal256 opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/141
TINKERPOP3-886
Let me know if exceptions should be managed any differently, or if you see any issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kushal256/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit 5c4e9660d7fdf3c6d3aa71dd3742a4f0d549cf01
Author: Kushal <ku...@foodinhood.com>
Date: 2015-11-08T00:44:43Z
TINKERPOP3-886: Allow any GraphReader/Writer to be persistence engine for TinkerGraph
commit 16faa852e350b4d06a1f600078b6604b568438a7
Author: Kushal <ku...@foodinhood.com>
Date: 2015-11-08T01:02:08Z
Merge remote-tracking branch 'upstream/master'
----
> Allow any GraphReader/Writer to be persistence engine for TinkerGraph
> ----------------------------------------------------------------------
>
> Key: TINKERPOP3-886
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-886
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Trivial
>
> TinkerGraph currently works with gryo, graphml and graphson - all internal formats to TinkerPop. This could easily be extended to work with any format implementing the appropriate interfaces (i.e. also external third-party formats) by allowing for the `gremlin.tinkergraph.graphFormat` setting for TinkerGraph to be set to the existing three settings, but also allow for it to be the fully qualified class name for a {{Io.Builder<I extends Io>}} interface. TinkerGraph could then dynamically instantiate this class (which we can expect to have a zero-arg constructor) and use it to load/save data. This might actually also clean up some of the existing code around load/save.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)