You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2014/05/14 02:05:20 UTC
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/763
Fix dep exclusion: avro-ipc, not avro, depends on netty.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark netty-dep-hell
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #763
----
commit dfb6ce227d9d5c876bb7bd497ce6ce79847f2dc4
Author: Marcelo Vanzin <va...@cloudera.com>
Date: 2014-05-14T00:04:24Z
Fix dep exclusion: avro-ipc, not avro, depends on netty.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/763#issuecomment-43045838
I see, so it's definitely avro-ipc that pulls it in? Makes sense. If you're not certain, leave them both. But this is good if it's only avro-ipc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/763#issuecomment-43028415
@srowen this fixes something that was still broken for me after c7253dae
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/763#issuecomment-43050895
I'll pull this in, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/763#issuecomment-43050874
I dug around through several different avro versions and it does seem that consistently `avro-ipc` brings in netty and `avro` doesn't directly bring it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/763#issuecomment-43028478
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fix dep exclusion: avro-ipc, not avro, depends...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---