[jira] [Work logged] (IMAGING-159) There should be a Parameters class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=622856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622856 ]

ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jul/21 05:24
            Start Date: 15/Jul/21 05:24
    Worklog Time Spent: 10m 
      Work Description: kinow commented on a change in pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#discussion_r670141981



##########
File path: src/main/java/org/apache/commons/imaging/Imaging.java
##########
@@ -735,32 +737,35 @@ public static ImageInfo getImageInfo(final File file) throws ImageReadException,
         return getImageInfo(file, null);
     }
 
-    private static ImageInfo getImageInfo(final ByteSource byteSource, final Map<String, Object> params)
-            throws ImageReadException, IOException {
-        return getImageParser(byteSource).getImageInfo(byteSource, params);
+    // See getImageParser
+    @SuppressWarnings("unchecked")
+    private static ImageInfo getImageInfo(final ByteSource byteSource, final ImagingParameters params) throws ImageReadException, IOException {
+        return Imaging.getImageParser(byteSource).getImageInfo(byteSource, params);
     }
 
-    private static ImageParser getImageParser(final ByteSource byteSource)
-            throws ImageReadException, IOException {
+    // TODO: We have no way of knowing whether the returned ImageParser will accept the ImagingParameters,
+    // even if we specified generic types for the static methods.

Review comment:
       Not sure if there's a better way of changing this method...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 622856)
    Time Spent: 4h 10m  (was: 4h)

> There should be a Parameters class
> ----------------------------------
>
>                 Key: IMAGING-159
>                 URL: https://issues.apache.org/jira/browse/IMAGING-159
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.*
>    Affects Versions: 1.0-alpha2
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>              Labels: github
>             Fix For: 1.0-alpha3
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
>   if (!(value instanceof Number)) {
>     throw new ImageWriteException(
>       "Invalid compression parameter, must be numeric: "
>          + value);
>   }
>   compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides additional methods like {{public int getInt(String key)}}. The implementation could then look up the value from the map through an exception if it is null or not a number.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)