You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2018/09/08 17:21:59 UTC
spark git commit: [SPARK-25375][SQL][TEST] Reenable qualified perm.
function checks in UDFSuite
Repository: spark
Updated Branches:
refs/heads/master 08c02e637 -> 26f74b7cb
[SPARK-25375][SQL][TEST] Reenable qualified perm. function checks in UDFSuite
## What changes were proposed in this pull request?
At Spark 2.0.0, SPARK-14335 adds some [commented-out test coverages](https://github.com/apache/spark/pull/12117/files#diff-dd4b39a56fac28b1ced6184453a47358R177
). This PR enables them because it's supported since 2.0.0.
## How was this patch tested?
Pass the Jenkins with re-enabled test coverage.
Closes #22363 from dongjoon-hyun/SPARK-25375.
Authored-by: Dongjoon Hyun <do...@apache.org>
Signed-off-by: gatorsmile <ga...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/26f74b7c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/26f74b7c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/26f74b7c
Branch: refs/heads/master
Commit: 26f74b7cb16869079aa7b60577ac05707101ee68
Parents: 08c02e6
Author: Dongjoon Hyun <do...@apache.org>
Authored: Sat Sep 8 10:21:55 2018 -0700
Committer: gatorsmile <ga...@gmail.com>
Committed: Sat Sep 8 10:21:55 2018 -0700
----------------------------------------------------------------------
.../org/apache/spark/sql/hive/UDFSuite.scala | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/26f74b7c/sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
index 88cc42e..a56c6f7 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
@@ -141,11 +141,10 @@ class UDFSuite
withTempDatabase { dbName =>
withUserDefinedFunction(functionName -> false) {
sql(s"CREATE FUNCTION $dbName.$functionName AS '$functionClass'")
- // TODO: Re-enable it after can distinguish qualified and unqualified function name
- // checkAnswer(
- // sql(s"SELECT $dbName.myuPPer(value) from $testTableName"),
- // expectedDF
- // )
+ checkAnswer(
+ sql(s"SELECT $dbName.$functionName(value) from $testTableName"),
+ expectedDF
+ )
checkAnswer(
sql(s"SHOW FUNCTIONS like $dbName.$functionNameUpper"),
@@ -174,11 +173,10 @@ class UDFSuite
// For this block, drop function command uses default.functionName as the function name.
withUserDefinedFunction(s"$dbName.$functionNameUpper" -> false) {
sql(s"CREATE FUNCTION $dbName.$functionName AS '$functionClass'")
- // TODO: Re-enable it after can distinguish qualified and unqualified function name
- // checkAnswer(
- // sql(s"SELECT $dbName.myupper(value) from $testTableName"),
- // expectedDF
- // )
+ checkAnswer(
+ sql(s"SELECT $dbName.$functionName(value) from $testTableName"),
+ expectedDF
+ )
sql(s"USE $dbName")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org