You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "moussaoutlook (via GitHub)" <gi...@apache.org> on 2026/07/12 08:39:07 UTC
[PR] fix(tests): correct stale TYPE_CHECKING import path in base_data_loader [superset]
moussaoutlook opened a new pull request, #41972:
URL: https://github.com/apache/superset/pull/41972
### SUMMARY
`tests/example_data/data_loading/base_data_loader.py:23` imports `tests.common.example_data.data_loading.data_definitions.types` under `TYPE_CHECKING`, but no `example_data` package exists under `tests/common/` — the real module is `tests/example_data/data_loading/data_definitions/types.py` (where `Table` is defined). Any type-check that resolves this file fails on the dead path.
One-line path fix. No runtime behavior change (import is `TYPE_CHECKING`-only).
Found while validating DACIP, a static contract-analysis tool I'm building, against open-source codebases; verified against `49dc0acd827ae59845dc079e980a0ff701114396` (master, 2026-07-12).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
### TESTING INSTRUCTIONS
`ls tests/common/` — no `example_data` package exists there. `ls tests/example_data/data_loading/data_definitions/types.py` — the real module. After the change, the `TYPE_CHECKING` import resolves; `mypy tests/example_data/data_loading/base_data_loader.py` no longer reports the missing module.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): correct stale TYPE_CHECKING import path in base_data_loader [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #41972:
URL: https://github.com/apache/superset/pull/41972#issuecomment-4951307438
Thank you. I can verify the fix is correct but it's weird that a Playwright E2E test would fail at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): correct stale TYPE_CHECKING import path in base_data_loader [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41972:
URL: https://github.com/apache/superset/pull/41972#issuecomment-4950554944
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): correct stale TYPE_CHECKING import path in base_data_loader [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41972:
URL: https://github.com/apache/superset/pull/41972#issuecomment-4950603634
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41972?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.99%. Comparing base ([`49dc0ac`](https://app.codecov.io/gh/apache/superset/commit/49dc0acd827ae59845dc079e980a0ff701114396?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`60e83a5`](https://app.codecov.io/gh/apache/superset/commit/60e83a5d6fdfd0470b618ac5ff0d1c01bdca9634?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (49dc0ac) and HEAD (60e83a5). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (49dc0ac) | HEAD (60e83a5) |
>|------|------|------|
>|hive|3|1|
>|python|18|2|
>|presto|3|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41972 +/- ##
==========================================
- Coverage 64.87% 55.99% -8.89%
==========================================
Files 2742 2742
Lines 153378 153378
Branches 35168 35168
==========================================
- Hits 99509 85880 -13629
- Misses 51962 66672 +14710
+ Partials 1907 826 -1081
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.07% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.06% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.11% <ø> (-18.29%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41972?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): correct stale TYPE_CHECKING import path in base_data_loader [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #41972:
URL: https://github.com/apache/superset/pull/41972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org