You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Lewuathe <gi...@git.apache.org> on 2014/11/29 16:23:49 UTC
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
GitHub user Lewuathe opened a pull request:
https://github.com/apache/spark/pull/3513
[SPARK-4652][DOCS] Add docs about spark-git-repo option
There might be some times when WIPS spark version need to be run
on EC2 cluster. In order to setup this type of cluster more easily,
add --spark-git-repo option description to ec2 documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lewuathe/spark doc-for-development-spark-cluster
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3513
----
commit cfaf9be21141856c2b9ec5bb795fe53c2a222176
Author: lewuathe <le...@me.com>
Date: 2014-11-29T15:12:08Z
Add docs about spark-git-repo option
There might be some times when WIPS spark version need to be run
on EC2 cluster. In order to setup this type of cluster more easily,
add --spark-git-repo option description to ec2 documentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3513#issuecomment-64955155
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
Posted by Lewuathe <gi...@git.apache.org>.
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/3513#issuecomment-65725886
@JoshRosen Thank you for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3513#issuecomment-65721200
This looks good to me. There's one minor sentence-ordering and capitalization issue that I'd like to fix, but I'll do it myself on merge. I'm going to merge this into `master`, `branch-1.2`, and `branch-1.1`. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/3513#discussion_r21057603
--- Diff: docs/ec2-scripts.md ---
@@ -85,6 +85,8 @@ another.
specified version of Spark. The `<version>` can be a version number
(e.g. "0.7.3") or a specific git hash. By default, a recent
version will be used.
+- `--spark-git-repo=<repository url>` enables you to run your development version on EC2 cluster. You need to set `--spark-version`
--- End diff --
Can you wrap the text here consistent with the rest of the file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4652][DOCS] Add docs about spark-git-re...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3513#discussion_r21344431
--- Diff: docs/ec2-scripts.md ---
@@ -85,6 +85,11 @@ another.
specified version of Spark. The `<version>` can be a version number
(e.g. "0.7.3") or a specific git hash. By default, a recent
version will be used.
+- `--spark-git-repo=<repository url>` enables you to run your
+ development version on EC2 cluster. You need to set
+ `--spark-version` as git commit hash such as 317e114 not
+ original release version number. By default, this repository is
+ set [apache mirror](https://github.com/apache/spark).
--- End diff --
"Apache" needs to be capitalized here. I'd also swap the order of these sentences so that the default for `--spark-git-repo` appears first, followed by the sentence describing how `--spark-version` needs to be set when using this option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org