[GitHub] [yetus] ndimiduk commented on a change in pull request #160: YETUS-992. Create and publish a github action (more)

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #160:
URL: https://github.com/apache/yetus/pull/160#discussion_r505875685



##########
File path: start-build-env.sh
##########
@@ -92,14 +92,26 @@ cd "${ROOTDIR}"
 # release managers can use the container to do releases
 
 dockerargs=(--rm=true)
-dockerargs+=(-v "${PWD}:/home/${USER_NAME}/yetus${V_OPTS:-}")
 dockerargs+=(-w "/home/${USER_NAME}/yetus")
+dockerargs+=(-v "${PWD}:/home/${USER_NAME}/yetus${V_OPTS:-}")
+
+# maven cache
+if [[ ! -d  ${HOME}/.m2 ]]; then
+  mkdir "${HOME}/.m2"
+fi
+dockerargs+=(-v "${HOME}/.m2:/home/${USER_NAME}/.m2${V_OPTS:-}")
+
+# GPG Signing for dist creation
+if [[ ! -d ${HOME}/.gnupg ]]; then
+  mkdir "${HOME}/.gnupg"
+fi
+dockerargs+=(-v "${HOME}/.gnupg:/home/${USER_NAME}/.gnupg${V_OPTS:-}")
 
-if [[ -z ${GITHUB_ACTIONS} ]]; then
-  dockerargs+=(-v "${HOME}/.m2:/home/${USER_NAME}/.m2${V_OPTS:-}")
-  dockerargs+=(-v "${HOME}/.gnupg:/home/${USER_NAME}/.gnupg")
-  dockerargs+=(-v "${HOME}/.ssh:/home/${USER_NAME}/.ssh")
+# git opertions
+if [[ ! -d ${HOME}/.ssh ]]; then
+  mkdir "${HOME}/.ssh"
 fi
+dockerargs+=(-v "${HOME}/.ssh:/home/${USER_NAME}/.ssh${V_OPTS:-}")

Review comment:
       There's not a better way to pass key materials into the docker process? I'd hope for some solution other than making the private keys visible to the process, something like agent forwarding.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org