You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Daniel Caldeweyher (JIRA)" <de...@tapestry.apache.org> on 2008/02/27 05:52:57 UTC
[jira] Created: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores undeling model
LabeledPropertySelectionModel.isDisabled ignores undeling model
---------------------------------------------------------------
Key: TAPESTRY-2201
URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
Project: Tapestry
Issue Type: Bug
Components: Core Components
Affects Versions: 4.1.5
Reporter: Daniel Caldeweyher
LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
public boolean isDisabled(int index) {
return index == 0 && _option == null;
}
should be replaced with:
public boolean isDisabled(int index) {
return index == 0 ? _option == null : _model.isDisabled(index - 1);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores underlying model
Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573105#action_12573105 ]
Andreas Andreou commented on TAPESTRY-2201:
-------------------------------------------
Fixed - nice catch, thx!
> LabeledPropertySelectionModel.isDisabled ignores underlying model
> -----------------------------------------------------------------
>
> Key: TAPESTRY-2201
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components
> Affects Versions: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
> Reporter: Daniel Caldeweyher
> Assignee: Andreas Andreou
> Priority: Minor
> Fix For: 4.1.6
>
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
> public boolean isDisabled(int index) {
> return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
> return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores underlying model
Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Andreou updated TAPESTRY-2201:
--------------------------------------
Fix Version/s: 4.1.6
Assignee: Andreas Andreou
> LabeledPropertySelectionModel.isDisabled ignores underlying model
> -----------------------------------------------------------------
>
> Key: TAPESTRY-2201
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components
> Affects Versions: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
> Reporter: Daniel Caldeweyher
> Assignee: Andreas Andreou
> Priority: Minor
> Fix For: 4.1.6
>
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
> public boolean isDisabled(int index) {
> return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
> return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores underlying model
Posted by "Daniel Caldeweyher (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Caldeweyher updated TAPESTRY-2201:
-----------------------------------------
Summary: LabeledPropertySelectionModel.isDisabled ignores underlying model (was: LabeledPropertySelectionModel.isDisabled ignores undeling model)
> LabeledPropertySelectionModel.isDisabled ignores underlying model
> -----------------------------------------------------------------
>
> Key: TAPESTRY-2201
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components
> Affects Versions: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
> Reporter: Daniel Caldeweyher
> Priority: Minor
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
> public boolean isDisabled(int index) {
> return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
> return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores undeling model
Posted by "Daniel Caldeweyher (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Caldeweyher updated TAPESTRY-2201:
-----------------------------------------
Affects Version/s: 4.1
4.1.1
4.1.2
4.1.3
> LabeledPropertySelectionModel.isDisabled ignores undeling model
> ---------------------------------------------------------------
>
> Key: TAPESTRY-2201
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components
> Affects Versions: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
> Reporter: Daniel Caldeweyher
> Priority: Minor
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
> public boolean isDisabled(int index) {
> return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
> return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores underlying model
Posted by "Andreas Andreou (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Andreou resolved TAPESTRY-2201.
---------------------------------------
Resolution: Fixed
> LabeledPropertySelectionModel.isDisabled ignores underlying model
> -----------------------------------------------------------------
>
> Key: TAPESTRY-2201
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components
> Affects Versions: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
> Reporter: Daniel Caldeweyher
> Assignee: Andreas Andreou
> Priority: Minor
> Fix For: 4.1.6
>
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
> public boolean isDisabled(int index) {
> return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
> return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2201)
LabeledPropertySelectionModel.isDisabled ignores undeling model
Posted by "Daniel Caldeweyher (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Caldeweyher updated TAPESTRY-2201:
-----------------------------------------
Priority: Minor (was: Major)
> LabeledPropertySelectionModel.isDisabled ignores undeling model
> ---------------------------------------------------------------
>
> Key: TAPESTRY-2201
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2201
> Project: Tapestry
> Issue Type: Bug
> Components: Core Components
> Affects Versions: 4.1.5
> Reporter: Daniel Caldeweyher
> Priority: Minor
>
> LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.
> public boolean isDisabled(int index) {
> return index == 0 && _option == null;
> }
> should be replaced with:
> public boolean isDisabled(int index) {
> return index == 0 ? _option == null : _model.isDisabled(index - 1);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org