You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/02 17:07:53 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #5222: [DOCS] Misc
docs improvements
tqchen opened a new pull request #5222: [DOCS] Misc docs improvements
URL: https://github.com/apache/incubator-tvm/pull/5222
- Reduce CI docs task log size.
- Update the relation to halide to the latest state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5222: [DOCS] Misc docs
improvements
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5222: [DOCS] Misc docs improvements
URL: https://github.com/apache/incubator-tvm/pull/5222#issuecomment-607973983
cc @yzhliu @ZihengJiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #5222: [DOCS] Misc docs
improvements
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5222: [DOCS] Misc docs improvements
URL: https://github.com/apache/incubator-tvm/pull/5222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #5222:
[DOCS] Misc docs improvements
Posted by GitBox <gi...@apache.org>.
yzhliu commented on a change in pull request #5222: [DOCS] Misc docs improvements
URL: https://github.com/apache/incubator-tvm/pull/5222#discussion_r402500515
##########
File path: README.md
##########
@@ -41,7 +41,7 @@ Checkout the [Contributor Guide](https://tvm.apache.org/docs/contribute/)
Acknowledgement
---------------
We learned a lot from the following projects when building TVM.
-- [Halide](https://github.com/halide/Halide): TVM uses [HalideIR](https://github.com/dmlc/HalideIR) as data structure for
- arithmetic simplification and low level lowering. We also learned and adapted some part of lowering pipeline from Halide.
+- [Halide](https://github.com/halide/Halide): Part of TVM's TIR and arithmetic simplification module
+ originates form Halide. We also learned and adapted some part of lowering pipeline from Halide.
Review comment:
from?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5222:
[DOCS] Misc docs improvements
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5222: [DOCS] Misc docs improvements
URL: https://github.com/apache/incubator-tvm/pull/5222#discussion_r402501380
##########
File path: README.md
##########
@@ -41,7 +41,7 @@ Checkout the [Contributor Guide](https://tvm.apache.org/docs/contribute/)
Acknowledgement
---------------
We learned a lot from the following projects when building TVM.
-- [Halide](https://github.com/halide/Halide): TVM uses [HalideIR](https://github.com/dmlc/HalideIR) as data structure for
- arithmetic simplification and low level lowering. We also learned and adapted some part of lowering pipeline from Halide.
+- [Halide](https://github.com/halide/Halide): Part of TVM's TIR and arithmetic simplification module
+ originates form Halide. We also learned and adapted some part of lowering pipeline from Halide.
Review comment:
good catch, addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services