You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/24 22:38:37 UTC

[GitHub] [incubator-druid] surekhasaharan opened a new pull request #8154: Fix `is_realtime` column behavior in sys.segments table

surekhasaharan opened a new pull request #8154: Fix `is_realtime` column behavior in sys.segments table
URL: https://github.com/apache/incubator-druid/pull/8154
 
 
   Fixes #8142 
   
   ### Description
   
   Update the `isRealtime` flag when a segment is dropped by a realtime task.
   In `DruidSchema` added a check in `removeServerSegment()` when none of the replicas is a realtime server type, mark `isRealtime=0`.
   Added unit test.
   
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org