You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/24 14:19:50 UTC
[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request #110: [FLINK-26836] Add sanity check for state.savepoints.dir when using savepoint upgrade mode
SteNicholas opened a new pull request #110:
URL: https://github.com/apache/flink-kubernetes-operator/pull/110
Add sanity check for `state.savepoints.dir` when using savepoint upgrade mode and manually triggering endpoint for the running job.
**The brief change log**
- `DefaultDeploymentValidator` adds the check for `state.savepoints.dir` when the upgrade mode is `SAVEPOINT` or `savepointTriggerNonce` isn't null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #110: [FLINK-26836] Add sanity check for state.savepoints.dir when using savepoint upgrade mode
Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #110:
URL: https://github.com/apache/flink-kubernetes-operator/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #110: [FLINK-26836] Add sanity check for state.savepoints.dir when using savepoint upgrade mode
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #110:
URL: https://github.com/apache/flink-kubernetes-operator/pull/110#discussion_r834426653
##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##########
@@ -146,6 +148,22 @@
return Optional.of("Job could not be upgraded with last-state while HA disabled");
}
+ if (StringUtils.isNullOrWhitespaceOnly(
+ Configuration.fromMap(confMap)
Review comment:
We could move `Configuration.fromMap(confMap)` to a variable and reuse in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org