You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/25 02:33:53 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
v01d opened a new pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101
## Summary
This change supersedes #1843 which was stalled for some time and I found this change is simpler and solves the problem of object files not being cleaned when sources from sub-directories are added (typically for third party code where you can't place a Make.defs file at the same level of each source file to be built).
Ideally only $(OBJS) should be necessary and not *$(OBJEXT) but in #1843 it was mentioned that it was better to leave both cases.
## Impact
Should not break anything, only potentially removes object files not removed just with *$(OBJEXT)
## Testing
Fixed problem of left object files when compiling source files in subdirectory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101#discussion_r511611346
##########
File path: tools/Config.mk
##########
@@ -474,7 +474,7 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(OBJS) $(BIN)
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101#issuecomment-716166047
Let's merge it now, since we don't have automation build on Windows yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101#discussion_r511610716
##########
File path: tools/Config.mk
##########
@@ -474,7 +474,7 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(OBJS) $(BIN)
Review comment:
Ah, you meant the lines above. I just force pushed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101#discussion_r511607535
##########
File path: tools/Config.mk
##########
@@ -474,7 +474,7 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(OBJS) $(BIN)
Review comment:
but, should we modify the windows case too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2101: Add $(OBJS) and $(BIN) to CLEAN macro to clean objects also in subdirectories
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2101:
URL: https://github.com/apache/incubator-nuttx/pull/2101#discussion_r511609271
##########
File path: tools/Config.mk
##########
@@ -474,7 +474,7 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp $(OBJS) $(BIN)
Review comment:
Right, I keep forgetting about the other makefile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org