You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2023/07/16 14:51:15 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request, #32634: Remove click upper bound
pierrejeambrun opened a new pull request, #32634:
URL: https://github.com/apache/airflow/pull/32634
closes: https://github.com/apache/airflow/issues/32412
Remove upper bound limit on click, `8.1.5` is out with a fix:
https://click.palletsprojects.com/en/8.1.x/changes/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun closed pull request #32634: Remove click upper bound
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #32634: Remove click upper bound
URL: https://github.com/apache/airflow/pull/32634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32634: Remove click upper bound
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1642837831
> Or if there are, then specifically alexcluding those buggy version could be a good idea instead
Good idea, done. 8.1.4 and 8.1.5 are now excluded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #32634: Remove click upper bound
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1637404057
Converting to draft to avoid accidental merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32634: Remove click upper bound
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32634:
URL: https://github.com/apache/airflow/pull/32634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32634: Remove click upper bound
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1641806434
Should we make it >= 8.1.6 maybe ? I think there is no downside in requiring the newer version of click?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32634: Remove click upper bound
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1641807908
Or if there are, then specifically alexcluding those buggy version could be a good idea instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32634: Remove click upper bound
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1641118089
Click 8.1.6 was just released, retrying the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32634: Remove click upper bound
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1637152335
8.1.5 patch is not enough, tried locally with https://github.com/pallets/click/pull/2565 and it works. This will have to wait for `8.1.6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32634: Remove click upper bound
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1641719816
> We may need to update the PR description to reflect the updated click version that fixes the issue instead of the current mention for `8.1.5`
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32634: Remove click upper bound
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1643139410
random errors. merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32634: Remove click upper bound
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32634:
URL: https://github.com/apache/airflow/pull/32634#issuecomment-1637144745
Brings new mypy errors, I am taking a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org