You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "GChuf (via GitHub)" <gi...@apache.org> on 2026/09/03 08:32:39 UTC

Re: [PR] ARTEMIS-6042 Improve ArtemisMBeanServerGuard.canInvoke implementation [artemis]

GChuf commented on PR #6403:
URL: https://github.com/apache/artemis/pull/6403#issuecomment-5522922216

   The current tests passed because the existing tests only test the `getRolesForObject` method directly.
   I duplicated the tests, so that the `authorizeUserForMethod` is now tested as well.
   I also added 2 tests to test wildcards in keys.
   
   The tests can be deduplicated after changing the `handleInvoke` method to use authorizeUserForMethod as well.
   Waiting on your input here.
   
   The scenarios you mentioned are now solved by setting a prefix to `*` and looping through `bucketedMap.get("*")`'s regexp patterns if no exact match or regexp match was found earlier.
   I'm not sure if the logic for setting the prefix to * is the best way to handle it, but it should cover all the scenarios with wildcards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org