You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by paulk-asert <gi...@git.apache.org> on 2017/05/25 13:38:54 UTC
[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/551
GROOVY-8204: @Delegate on arrays causes NPE during compilation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/551.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #551
----
commit 8af2cf43dcf41d1614e75c1bb17046351c048472
Author: paulk <pa...@asert.com.au>
Date: 2017-05-25T13:37:14Z
GROOVY-8204: @Delegate on arrays causes NPE during compilation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...
Posted by jwagenleitner <gi...@git.apache.org>.
Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/551#discussion_r118507014
--- Diff: src/main/org/codehaus/groovy/ast/ClassHelper.java ---
@@ -440,12 +440,15 @@ private static boolean hasUsableImplementation(ClassNode c, MethodNode m) {
/**
* Returns a super class or interface for a given class depending on a given target.
* If the target is no super class or interface, then null will be returned.
+ * For a non=primitive array type, returns an array of the componentType's superclass.
--- End diff --
non-primitive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request #551: GROOVY-8204: @Delegate on arrays causes NPE during...
Posted by paulk-asert <gi...@git.apache.org>.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/551#discussion_r118622384
--- Diff: src/main/org/codehaus/groovy/ast/ClassHelper.java ---
@@ -440,12 +440,15 @@ private static boolean hasUsableImplementation(ClassNode c, MethodNode m) {
/**
* Returns a super class or interface for a given class depending on a given target.
* If the target is no super class or interface, then null will be returned.
+ * For a non=primitive array type, returns an array of the componentType's superclass.
--- End diff --
fixed the typo, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---