You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/25 11:35:27 UTC

[GitHub] [incubator-inlong] healchow commented on a change in pull request #2705: [INLONG-2676][Manager] Support stop / restart / finish agent task

healchow commented on a change in pull request #2705:
URL: https://github.com/apache/incubator-inlong/pull/2705#discussion_r814697046



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/source/SourceRequest.java
##########
@@ -68,4 +68,6 @@
     @ApiModelProperty("Heartbeat of the source task")
     private String heartbeat;
 
+    @ApiModelProperty("Status")

Review comment:
       It's not recommended to add a status field in the request.
   
   Operations that modify status should be encapsulated into a separate interface.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org