[DISCUSS] Cordova-Common 3.2.1 Release

[Bryan Ellis <er...@apache.org>]

Does anyone have any reason to delay a cordova-common patch release (3.2.1)?
Any outstanding patches to land?

If not, I will start the release process shortly. (<24h).

Re: [DISCUSS] Cordova-Common 3.2.1 Release

[Bryan Ellis <er...@apache.org>]

@Brody

The removal of those test cases is expected because the original PR
introduced them to validate the changes that were to resolve the incorrect
config munging count. Because of the incorrect count, when uninstalling
plugin, it can be seen that the recovery process of the AndroidManifest and
Info.plist can be wrong and some things are not removed as expected. As the
past work around, the end-user could delete the platforms and run prepare
which would re-install the platforms and plugins.

Since the PR was reverted, the AndroidManifest and Info.plist recovery bug
would be re-introduced but fixes the plugin install issue that was
introduced from the original PR. This install issue is a major issue that
has higher priority. As for the incorrect config munge count and uninstall
issue, it is expected to be fix in a later release and most likely in the
next major. The user can use the original work around.

If any of the removed test cases were valid beyond the originals PR intent,
then they should have submitted them in a separate PR.

There were some changes in the PR that were not related to the original
intent and was discussed in the revert PR. Those items were cherry-picked
to remain in master (modified if needed).

I hope this clears up your concerns.


On Fri, Nov 1, 2019 at 12:13 PM Chris Brody <ch...@gmail.com> wrote:

> I took a quick look at the VOTE thread, unfortunately I did not have much
> time to understand what is going on with the reverted PR in the past.
> Unfortunately I do not really understand too well what is going on with
> both the forward change and the backward change.
>
> From a quick look, my understanding is that there are also test updates,
> which seem to make sense (I worked on some of them), and support for jsproj
> in XML files.
>
> One thing that bothers me is that when the PR was reverted, a bunch of test
> cases disappeared and I don't really understand why. I think it would be
> good to somehow show that the change in behavior is correct and remains
> correct moving forward.
>
> Some kind of a simple, step-by-step explanation would really help me and I
> think it would help others as well.
>
> On Wed, Sep 18, 2019 at 11:52 PM Bryan Ellis <er...@apache.org> wrote:
>
> > Does anyone have any reason to delay a cordova-common patch release
> > (3.2.1)?
> > Any outstanding patches to land?
> >
> > If not, I will start the release process shortly. (<24h).
> >
>

Re: [DISCUSS] Cordova-Common 3.2.1 Release

[Chris Brody <ch...@gmail.com>]

I took a quick look at the VOTE thread, unfortunately I did not have much
time to understand what is going on with the reverted PR in the past.
Unfortunately I do not really understand too well what is going on with
both the forward change and the backward change.

From a quick look, my understanding is that there are also test updates,
which seem to make sense (I worked on some of them), and support for jsproj
in XML files.

One thing that bothers me is that when the PR was reverted, a bunch of test
cases disappeared and I don't really understand why. I think it would be
good to somehow show that the change in behavior is correct and remains
correct moving forward.

Some kind of a simple, step-by-step explanation would really help me and I
think it would help others as well.

On Wed, Sep 18, 2019 at 11:52 PM Bryan Ellis <er...@apache.org> wrote:

> Does anyone have any reason to delay a cordova-common patch release
> (3.2.1)?
> Any outstanding patches to land?
>
> If not, I will start the release process shortly. (<24h).
>

Re: [DISCUSS] Cordova-Common 3.2.1 Release

[Tim Brust <ti...@sinnerschrader.com.INVALID>]

Friendly reminder- are you still working on this? :)

On Thu, Sep 19, 2019 at 3:52 AM Bryan Ellis <er...@apache.org> wrote:

> Does anyone have any reason to delay a cordova-common patch release
> (3.2.1)?
> Any outstanding patches to land?
>
> If not, I will start the release process shortly. (<24h).
>


-- 
Tim Brust, Product Engineer

tim.brust@sinnerschrader.com
T +49 40 398855 315

SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Völckersstraße 38, 22765 Hamburg, Germany

Amtsgericht Hamburg HRB-Nr. 63663
Geschäftsführer: Matthias Schrader (Sprecher),
Jürgen Alker, Dr. Axel Averdung, Holger Blank,
Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson

Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag

https://www.sinnerschrader.com | NEXT AGENCY