You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/30 01:06:28 UTC
[GitHub] [cassandra] rocco408 opened a new pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
rocco408 opened a new pull request #660:
URL: https://github.com/apache/cassandra/pull/660
…n frozen columns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jasonstack commented on a change in pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
Posted by GitBox <gi...@apache.org>.
jasonstack commented on a change in pull request #660:
URL: https://github.com/apache/cassandra/pull/660#discussion_r454425619
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java
##########
@@ -175,7 +175,9 @@ private void validateIndexTarget(TableMetadata table, IndexTarget target)
throw ire("Cannot create secondary index on the only partition key column %s", column);
if (column.type.isFrozenCollection() && target.type != Type.FULL)
- throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support full() indexes", target.type, column);
+ throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support indexes on the " +
Review comment:
@BrynCooke nice suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #660:
URL: https://github.com/apache/cassandra/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] BrynCooke commented on a change in pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
Posted by GitBox <gi...@apache.org>.
BrynCooke commented on a change in pull request #660:
URL: https://github.com/apache/cassandra/pull/660#discussion_r454230687
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java
##########
@@ -175,7 +175,9 @@ private void validateIndexTarget(TableMetadata table, IndexTarget target)
throw ire("Cannot create secondary index on the only partition key column %s", column);
if (column.type.isFrozenCollection() && target.type != Type.FULL)
- throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support full() indexes", target.type, column);
+ throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support indexes on the " +
Review comment:
Suggest a slightly different wording:
```
"Cannot create %s() index on frozen column %s. Frozen collections are immutable and must be fully indexed " +
"by using the FULL(<column-name>) modifier"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] rocco408 closed pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
Posted by GitBox <gi...@apache.org>.
rocco408 closed pull request #660:
URL: https://github.com/apache/cassandra/pull/660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] BrynCooke commented on a change in pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
Posted by GitBox <gi...@apache.org>.
BrynCooke commented on a change in pull request #660:
URL: https://github.com/apache/cassandra/pull/660#discussion_r454230687
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java
##########
@@ -175,7 +175,9 @@ private void validateIndexTarget(TableMetadata table, IndexTarget target)
throw ire("Cannot create secondary index on the only partition key column %s", column);
if (column.type.isFrozenCollection() && target.type != Type.FULL)
- throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support full() indexes", target.type, column);
+ throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support indexes on the " +
Review comment:
Suggest a slightly different wording:
```
"Cannot create %s() index on frozen column %s. Frozen collections are immutable and must be fully indexed " +
"by using the FULL(<column-name>) modifier"
```
Maybe even sub in the column name, but be aware that quotes may be needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] rocco408 commented on a change in pull request #660: CASSANDRA-15908: Added more details for full() indexing requirement o…
Posted by GitBox <gi...@apache.org>.
rocco408 commented on a change in pull request #660:
URL: https://github.com/apache/cassandra/pull/660#discussion_r454462091
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java
##########
@@ -175,7 +175,9 @@ private void validateIndexTarget(TableMetadata table, IndexTarget target)
throw ire("Cannot create secondary index on the only partition key column %s", column);
if (column.type.isFrozenCollection() && target.type != Type.FULL)
- throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support full() indexes", target.type, column);
+ throw ire("Cannot create %s() index on frozen column %s. Frozen collections only support indexes on the " +
Review comment:
done thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org