[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #1859: [KYUUBI #1838] Clean up query results after query operations finish

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #1859:
URL: https://github.com/apache/incubator-kyuubi/pull/1859#discussion_r795180025



##########
File path: externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/ExecuteStatement.scala
##########
@@ -209,6 +218,15 @@ class ExecuteStatement(
     setState(OperationState.FINISHED)
   }
 
+  private def cleanupQueryResult(resultId: String): Unit = {
+    try {
+      executor.cancelQuery(sessionId, resultId)
+    } catch {
+      case _: Throwable =>
+      // ignore further exceptions for cleanup

Review comment:
       @link3280, I don't think that this should keep aligned with Flink SQL Client. We could log here for the cancel exception so that the users could know canceling query cause the exception which may not cancel successfully.
   cc @pan3793 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org